-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request for comm(en|i)ts: Decoupling daemon from unvanquished #677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkdir unvanquished; cd unvanquished; ln -s ../* .; ln -s ../.* .; rm .git; rm unvanquished mkdir daemon; cd daemon; ln -s ../../* .; ln -s ../../.* .; rm .git; rm unvanquished Create Unvanquished CMakeLists.txt and `add_subdirectory(daemon)`; Needed changes in the combined CMakeLists: * CMAKE_SOURCE_DIR -> CMAKE_CURRENT_SOURCE_DIR * CMAKE_BINARY_DIR -> CMAKE_CURRENT_BINARY_DIR
TimePath
changed the title
Request for comments: Decoupling daemon from unvanquished
Request for comm(en|i)ts: Decoupling daemon from unvanquished
Mar 11, 2015
Gamelogic as the submodule: With gamelogic as the submodule, it would have to be updated every time it changed. With daemon as the submodule, this is also true, but far less frequent. |
Closing, new work here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: CMakeLists changes to reduce coupling between daemon and unvanquished.
cd unvanquished
first.Future improvements:
...