Fix memory leak by making NativeFinalizer instances static #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix memory leak by making NativeFinalizer instances static
The issue is that
NativeFinalizer
instances were being created as instance variables instead of static variables. According to Dart FFI best practices, finalizers should be static and shared across all instances of a class for proper memory management.Root Cause
Creating a new
NativeFinalizer
for each instance is inefficient and can prevent proper finalization:Solution
Tree
class (line 125)Parser
class (line 61)CancelToken
class (line 113)TreeCursor
class (line 145)Query
class (line 156)QueryCursor
class (line 246)ts_query_delete
instead ofts_query_cursor_delete
Expected Result
Memory usage when parsing 50k files should now:
The fix ensures one
NativeFinalizer
per class type, allowing efficient memory management by the Dart runtime.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.