Release updated modules: Percall, Chopping Kinky, Hexmix VCA, Kickall (v1.1.0 release) #20

hemmer · 2021-07-06T12:14:15Z

Pull request for #19 Release updated modules: Percall, Chopping Kinky, Hexmix VCA, Kickall (v1.1.0 release)

Leaving as a pull request first to allow @AndrewBelt time to review / add comments. I want to write as close to idiomatic Rack code as possible, especially as I am planning to do more modules in future, so any feedback is very welcome.

Includes @martin-lueders changes for polyphony, plus a little tidying up (e.g. using getPolyVoltageSimd to reduce boilerplate).

* use simd for polyphonic logic * only process CV / lights every N samples

* only up/downsample if needed

* some code cleanup * Percall strength should be calculated every sample

Made final row behaviour configurable in the menu (as is the case in the hardware).

- only downsample a source wave generated at higher sample rates - switch to Pade approximation of sin - new panel SVG from Befaco - fix LED logic Moved all chowdsp library code into specific header. Updated .json

Wire in VCA decay CV.

…d be applied

Signed-off-by: hemmer <915048+hemmer@users.noreply.github.com>

…nstead of 1.0.1. Signed-off-by: hemmer <915048+hemmer@users.noreply.github.com>

# Conflicts: # plugin.json # src/ABC.cpp # src/DualAtenuverter.cpp # src/EvenVCO.cpp # src/Mixer.cpp # src/Rampage.cpp # src/SlewLimiter.cpp # src/SpringReverb.cpp # src/plugin.hpp

* try older build machine for linux

* try to convert to idomatic Rack code * tightened up Percall/Hexmix polyphony logic

plugin.json

src/ABC.cpp

hemmer · 2021-07-06T12:21:27Z

I also want to add to readme, will it be possible to add screenshots to https://library.vcvrack.com/screenshots/Befaco/ ?

### Dual Atenuverter

Based on [Dual Atenuverter](http://www.befaco.org/dual-atenuverter/)

![Dual Atenuverter](https://library.vcvrack.com/screenshots/Befaco/DualAtenuverter.m.png)

…s redundant.

AndrewBelt

I've committed a couple fixes to the VCVRack/Befaco hemmer-v1 branch. Pull and push to that branch for future commits.

The reviewed lines shouldn't take too long to fix. The important points I'd like:

Initialize all variables (local and class fields), especially float_4
Remove explicit float_4(...) casts, just rely on implicit casts. Well-written SIMD code should look almost exactly like float code, so no need to pollute with unnecessary casts/lines.

src/EvenVCO.cpp

src/HexmixVCA.cpp

src/Percall.cpp

src/SlewLimiter.cpp

src/SpringReverb.cpp

.github/workflows/build-plugin.yml

src/EvenVCO.cpp

* use of string::f * removed unnecessary casts to float_4 * corrected/updated brace initialisation * removed github actions

src/ChoppingKinky.cpp

src/EvenVCO.cpp

src/ChoppingKinky.cpp

* fixing behavior of red light in reverb VU meter * removed more unnecessary casts to float_4

AndrewBelt · 2021-07-09T19:56:31Z

Looks good. Played with this a bit, felt like I was using my own Eurorack!

hemmer and others added 30 commits March 20, 2021 10:30

First pass at implementing Befaco Percall

1b80fd0

Fixed edge case where envelope would remain stuck.

4a9b8ee

Don't use zero based indexing for tooltips

e48a670

Cleaning up build depreciation warnings

0b83a68

Fix polyphony logic issue

acf9eaa

Performance improvements

389e249

* use simd for polyphonic logic * only process CV / lights every N samples

Added Hexmix VCA.

30536e4

Add prototype of Befaco Chopping Kinky

a92f2df

Switch to biquad for DC

b4241e0

* only up/downsample if needed

Implement new Befaco input/output ports

ecb4165

* some code cleanup * Percall strength should be calculated every sample

Added Kickall prototype (lots to fix!)

def1172

Added github build actions

6f40b01

Removed guide image from HexmixVCA.

31ad285

Made final row behaviour configurable in the menu (as is the case in the hardware).

Kickall

2667f30

- only downsample a source wave generated at higher sample rates - switch to Pade approximation of sin - new panel SVG from Befaco - fix LED logic Moved all chowdsp library code into specific header. Updated .json

Trial with the new Befaco bananuts for input/output distinction

040b221

Moving to generalised envelope class.

f11ecc2

Temporarily reset version number so testers aren't pestered to update.

ae3a404

Wire in VCA decay CV.

Added measured waveshaper responses for chopping kinky

9d854fe

Few bits of cleanup for Chopping Kinky, normal CV A -> B

87f3fe0

Tuning/calibration of Kickall sliders etc

dd7607f

Fix incorrect behaviour in AD envelopes for non-linear shapes

80db8f3

Updated to Befaco-supplied decals, fixed bug where negative gain woul…

80c6244

…d be applied

Tuning of Percall, and updating to Befaco supplied graphics

33a86f0

Fixed background colour of Percall

f65a530

Bumped version

b008301

polyphony part 1

bb2253f

Signed-off-by: hemmer <915048+hemmer@users.noreply.github.com>

interim commit

fe97947

Signed-off-by: hemmer <915048+hemmer@users.noreply.github.com>

poly Rampage

4936361

Signed-off-by: hemmer <915048+hemmer@users.noreply.github.com>

Rampage and Slewlimiter updated

25eb9cd

Signed-off-by: hemmer <915048+hemmer@users.noreply.github.com>

Polyphony finished

0cb2d2e

Signed-off-by: hemmer <915048+hemmer@users.noreply.github.com>

martin-lueders and others added 10 commits June 30, 2021 07:58

fixed seg fault in channelMask.apply*

c1241f6

Signed-off-by: hemmer <915048+hemmer@users.noreply.github.com>

Bugfix in PulseGenerator_4

2d67866

Signed-off-by: hemmer <915048+hemmer@users.noreply.github.com>

Code cleanup

fe50e81

Signed-off-by: hemmer <915048+hemmer@users.noreply.github.com>

slewlimiter bug fixed

2f176da

Signed-off-by: hemmer <915048+hemmer@users.noreply.github.com>

version number update -> 1.0.1

113d7b0

Signed-off-by: hemmer <915048+hemmer@users.noreply.github.com>

Fix formatting and other code quality issues. Bump version to 1.1.0 i…

1965399

…nstead of 1.0.1. Signed-off-by: hemmer <915048+hemmer@users.noreply.github.com>

Cleanup of SpringReverb

8e19c4d

Merge branch 'v1-poly' into v1

f8d8381

# Conflicts: # plugin.json # src/ABC.cpp # src/DualAtenuverter.cpp # src/EvenVCO.cpp # src/Mixer.cpp # src/Rampage.cpp # src/SlewLimiter.cpp # src/SpringReverb.cpp # src/plugin.hpp

Cleaning up polyphony post merge

0647a71

* try older build machine for linux

Remove lots of boilerplate by using set/getPolyVoltageSimd instead

c22e022

* try to convert to idomatic Rack code * tightened up Percall/Hexmix polyphony logic

hemmer commented Jul 6, 2021

View reviewed changes

plugin.json Outdated Show resolved Hide resolved

hemmer commented Jul 6, 2021

View reviewed changes

src/ABC.cpp Show resolved Hide resolved

hemmer requested a review from AndrewBelt July 6, 2021 12:21

AndrewBelt added 4 commits July 6, 2021 23:14

plugin.hpp is intended for shared plugin-wide symbols so Common.hpp i…

a9a0e4d

…s redundant.

Use Polyphonic tag instead of its alias Poly.

5df6cf1

Replace readme screenshots with VCV Library link.

a2cca6f

Code cleanup.

ff78c73

AndrewBelt reviewed Jul 7, 2021

View reviewed changes

hemmer added 2 commits July 7, 2021 17:01

Addressing review comments

411ec72

* use of string::f * removed unnecessary casts to float_4 * corrected/updated brace initialisation * removed github actions

Removed a couple of missed float_4 casts

26c4405

squinkylabs reviewed Jul 7, 2021

View reviewed changes

src/ChoppingKinky.cpp Show resolved Hide resolved

squinkylabs reviewed Jul 7, 2021

View reviewed changes

src/EvenVCO.cpp Show resolved Hide resolved

hemmer commented Jul 7, 2021

View reviewed changes

src/ChoppingKinky.cpp Show resolved Hide resolved

Addressing review comments

cf6e6d9

* fixing behavior of red light in reverb VU meter * removed more unnecessary casts to float_4

hemmer mentioned this pull request Jul 9, 2021

Befaco VCVRack/library#684

Closed

AndrewBelt merged commit 3b80c5c into VCVRack:v1 Jul 9, 2021

hemmer mentioned this pull request Jul 9, 2021

poly Befaco seems stable #13

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release updated modules: Percall, Chopping Kinky, Hexmix VCA, Kickall (v1.1.0 release) #20

Release updated modules: Percall, Chopping Kinky, Hexmix VCA, Kickall (v1.1.0 release) #20

hemmer commented Jul 6, 2021 •

edited

Loading

hemmer commented Jul 6, 2021

AndrewBelt left a comment

AndrewBelt commented Jul 9, 2021

Release updated modules: Percall, Chopping Kinky, Hexmix VCA, Kickall (v1.1.0 release) #20

Release updated modules: Percall, Chopping Kinky, Hexmix VCA, Kickall (v1.1.0 release) #20

Conversation

hemmer commented Jul 6, 2021 • edited Loading

hemmer commented Jul 6, 2021

AndrewBelt left a comment

Choose a reason for hiding this comment

AndrewBelt commented Jul 9, 2021

hemmer commented Jul 6, 2021 •

edited

Loading