Fixing typos and minor changes coming from todays merging frenzy #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ue71603
commented
Jan 20, 2023
•
ue71603
commented
- Malte has some typos found, but it was already merged. His comments are now in this PR
- Also redos the attribute change from Change order of attributes in WaitDuration to match other attributes #286
skinkie
approved these changes
Jan 20, 2023
skinkie
requested changes
Jan 20, 2023
skinkie
approved these changes
Jan 20, 2023
ue71603
changed the title
| <xs:enumeration value="unknown_turning_kind"/> | ||
| <!-- additional enum values for individual vehicles --> |
There was a problem hiding this comment.
Did you move those comments on purpose?
There was a problem hiding this comment.
no, I think this is something that the post processing in the script does. It doesn't like style comments within xs:enumeration. Perhaps we should remove them.
|
@skinkie Why did you merge this? The problem of those comments has not been solved. Either they should be put back to where they were or removed - but not be in the bottom of the element. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.