add stubs for internal classes #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apolyakov
requested changes
Sep 5, 2024
mkornaukhov03
requested changes
Sep 5, 2024
added 22 commits
September 6, 2024 11:29
astrophysik
force-pushed
the
vsadokhov/compile-unsupported-classes
branch
from
7262b87
to
cbbea14
Compare
added 2 commits
September 6, 2024 11:30
| @@ -65,7 +65,8 @@ function in_array ($value ::: any, $a ::: array, $strict ::: bool = false) ::: b | |||
| function array_fill ($start_index ::: int, $num ::: int, $value ::: any) ::: ^3[]; | |||
| function array_fill_keys ($a ::: array, $value ::: any) ::: ^2[]; | |||
| function array_combine ($keys ::: array, $values ::: array) ::: ^2; | |||
| function range ($from, $to, $step ::: int = 1) ::: mixed[];//TODO | |||
| /** @kphp-extern-func-info generate-stub */ | |||
| function range ($from ::: mixed, $to ::: mixed, $step ::: int = 1) ::: mixed[];//TODO | |||
There was a problem hiding this comment.
What does TODO comment mean here?
Please remove or provide better description
There was a problem hiding this comment.
I don't know. It came from _functions.txt. Remove it
compiler/data/class-data.cpp
Outdated
| @@ -354,8 +354,7 @@ bool ClassData::has_polymorphic_member_dfs(std::unordered_set<ClassPtr> &checked | |||
| } | |||
|
|
|||
| bool ClassData::does_need_codegen() const { | |||
| return !is_builtin() && !is_trait() && | |||
| (really_used || is_tl_class); | |||
| return (is_builtin() && need_generated_stub) || (!is_builtin() && !is_trait() && (really_used || is_tl_class)); | |||
There was a problem hiding this comment.
(is_builtin() && need_generated_stub) <=> need_generated_stub, but up to you
apolyakov
approved these changes
Sep 6, 2024
astrophysik
added a commit
that referenced
this pull request
Sep 17, 2024
Compile unsupported phpt test in k2 mode. Continuation of #1093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next part of #1078
General
Add notation
/** @kphp-generate-stub-class */for generating internal class stub. Also prohibit visitors for runtime lightMain changes in /compiler, /runtime-core