compile unsupported phpt tests #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrophysik
force-pushed
the
vsadokhov/compile-unsupported-phpt
branch
3 times, most recently
from
3ac1dfd
to
2688a4e
Compare
astrophysik
force-pushed
the
vsadokhov/compile-unsupported-phpt
branch
from
2688a4e
to
add1704
Compare
added 2 commits
September 12, 2024 19:02
apolyakov
requested changes
Sep 13, 2024
astrophysik
commented
Sep 16, 2024
| @@ -266,7 +266,8 @@ class ParseAndApplyPhpDocForFunction { | |||
| } | |||
|
|
|||
| case PhpDocType::kphp_extern_func_info: { | |||
| kphp_error(f_->is_extern(), "@kphp-extern-func-info used for regular function"); | |||
| // This is temporary solution for generate-stub | |||
There was a problem hiding this comment.
Please note here. I did it, because child classes with undeclared constructor get parent constructor
apolyakov
requested changes
Sep 17, 2024
apolyakov
reviewed
Sep 17, 2024
astrophysik
force-pushed
the
vsadokhov/compile-unsupported-phpt
branch
from
b3a323e
to
412f0fa
Compare
apolyakov
approved these changes
Sep 17, 2024
Danil42Russia
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next part of #1093
General
This pr add a lot of different fixes to make available to compile phpt tests from whitelist