-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compile unsupported phpt tests #1098
Conversation
3ac1dfd
to
2688a4e
Compare
2688a4e
to
add1704
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR seems good to me overall. Please, address comments, apply formatter, look at include
you use.
@@ -266,7 +266,8 @@ class ParseAndApplyPhpDocForFunction { | |||
} | |||
|
|||
case PhpDocType::kphp_extern_func_info: { | |||
kphp_error(f_->is_extern(), "@kphp-extern-func-info used for regular function"); | |||
// This is temporary solution for generate-stub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note here. I did it, because child classes with undeclared constructor get parent constructor
b3a323e
to
412f0fa
Compare
next part of #1093
General
This pr add a lot of different fixes to make available to compile phpt tests from whitelist