Fix #7159 bad handling of auto-surrounding selections

[Elliot-Roberts]

What this PR does / why we need it:
By default in VSCode with VSCodeVim disabled, selecting text and typing an opening bracket or quote will surround the selection, while keeping the selection, allowing for further non-surrounding keystrokes to overwrite the selected text.

Currently, with VSCodeVim enabled, in insert mode the functionality is still partially present, but broken.
The text gets surrounded, but the selection is lost, and the cursor is placed one character short of the right end.

This is a pain when filling in snippet holes with strings.
I want to be able to just type my new text in, but when VSCodeVim is enabled, if I am inserting a string or bracketed expression, I have to delete the placeholder text first to prevent it from interfering.
e.g. if the selected placeholder is name and I type in "Jeff, I get "namJeffe" when I wanted "Jeff".

This PR fixes the behavior in insert mode to match the vim-disabled behavior.

Which issue(s) this PR fixes
Fixes #7159

Special notes for your reviewer:
I did not get super familiar with the codebase. I hope you can pardon the tacked-on quality of the additions. They at least do not break existing tests, and I'm of course open to suggestions for restructuring.

Thanks :)

[J-Fields]

Looks good to me, thanks!

[szechp]

is there a way to improve this to add surroundings for visual selections? right now i have to go to insert mode, shift select and then press " to surround a word.

[Elliot-Roberts]

VSCodeVim includes emulation of the surround.vim vim plugin, which is a popular solution for surrounding in vim. Does that work for you?
The auto-surrounding behavior in insert mode comes from VSCode natively and operates on "VSCode-style" selections.
Visual mode selections are a vim concept, and so have a more vim-style solution.

[szechp]

I'm coming from astronvim, which has leader+s+a to add surrounding (and a bunch of others to replace etc) so at first I wanted a way to rebind vscode vom to that, which is not working BC surround does net let me rebind. I have my problems with surround, I don't want y to be a leader, I don't want S to be remapped, for instance. So I was hoping for the easy solution namely using visual selection and " to do this. But I figured this runs in a lot of other issues since brackets are remapped somewhere else, so I will just get used to one of the new ways that currently work 🤷‍♂️ but thanks for the quick reply

…

On Thu, 14 Sep 2023, 11:01 Elliot-Roberts, ***@***.***> wrote: VSCodeVim includes emulation of the surround.vim vim plugin <https://github.com/VSCodeVim/Vim#vim-surround>, which is a popular solution for surrounding in vim. Does that work for you? The auto-surrounding behavior in insert mode comes from VSCode natively and operates on "VSCode-style" selections. Visual mode selections are a vim concept, and so have a more vim-style solution. — Reply to this email directly, view it on GitHub <#8533 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKZLFNG5RTFGVIRH4QLUGJ3X2LBYNANCNFSM6AAAAAA3L22EOU> . You are receiving this because you commented.Message ID: ***@***.***>