Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement normal command #8896

Merged
merged 46 commits into from
Jun 30, 2024
Merged

Implement normal command #8896

merged 46 commits into from
Jun 30, 2024

Conversation

s-kai273
Copy link
Contributor

@s-kai273 s-kai273 commented Feb 21, 2024 •
edited
Loading

What this PR does / why we need it:

  • implement normal command(both for single line and multi lines)
  • test codes of normal command

Which issue(s) this PR fixes

Special notes for your reviewer

  • hope to check implementation design is proper
    it is designed referring to macro implementation.

@s-kai273 s-kai273 mentioned this pull request Feb 21, 2024
Closed
feeiyu
feeiyu reviewed Feb 23, 2024
View reviewed changes
src/transformations/execute.ts Outdated
for (const line of resultLines) {
vimState.cursorStopPosition = vimState.cursorStartPosition =
TextEditor.getFirstNonWhitespaceCharOnLine(vimState.document, line.lineNumber);
await modeHandler.handleMultipleKeyEvents(keystroke.value);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to call rerunRecordedState from the second line？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean that dot command is working properly or not?
actually :normal . is doing well..

s-kai273
s-kai273 commented Mar 15, 2024
View reviewed changes
test/normalCommand.test.ts Outdated Show resolved Hide resolved
@s-kai273
Copy link
Contributor Author

I implemented test codes.
If it is necessary to add more test cases, please tell me it.

@s-kai273
Copy link
Contributor Author

@J-Fields @feeiyu

Hi,
I have completed the revisions to my code as per your comments. If there are any additional adjustments needed, please let me know.

Thank you for your feedback.

@s-kai273
Copy link
Contributor Author

After merging #8979, some conflicts occurred.
I have fixed them in commit dbd0bd2.

@s-kai273
Copy link
Contributor Author

@J-Fields
Thank you for your review.
I have addressed all the points you mentioned.

@s-kai273 s-kai273 requested a review from J-Fields May 27, 2024 03:16
@J-Fields
Copy link
Member

@s-kai273 Just one more unresolved comment: #8896 (comment)

@s-kai273
Copy link
Contributor Author

@J-Fields
Thanks, I fixed #8896 (comment).
Please check it!

J-Fields
J-Fields approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@J-Fields J-Fields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@J-Fields J-Fields merged commit 0f4c21c into VSCodeVim:master Jun 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-Fields J-Fields J-Fields approved these changes

@feeiyu feeiyu Awaiting requested review from feeiyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s-kai273 @J-Fields @feeiyu