Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save GHDL args to JSON file #581

Closed
wants to merge 2 commits into from
Closed

Save GHDL args to JSON file #581

wants to merge 2 commits into from

Conversation

umarcor
Copy link
Member

@umarcor umarcor commented Oct 30, 2019 •
edited
Loading

Close #579

In the first commit of this PR, ghdl_interface is refactored to:

  • Accumulate compilation and simulation arguments in separate variables.
  • Manipulate/generate all the arguments in _get_command, not in simulate.

In the second commit, runtime arguments (cmd and sim) are saved to a args.JSON file when ghdl_e is used.

@umarcor umarcor mentioned this pull request Nov 12, 2019
Draft
1 task
@umarcor umarcor force-pushed the feat-ghdl-args branch 3 times, most recently from 183579c to 8a13a83 Compare November 17, 2019 01:33
@umarcor umarcor force-pushed the feat-ghdl-args branch 3 times, most recently from 6ab55e1 to 6bd12e3 Compare December 2, 2019 06:17
@umarcor umarcor mentioned this pull request Feb 19, 2020
Merged
@umarcor umarcor closed this Feb 20, 2020
@umarcor umarcor deleted the feat-ghdl-args branch February 20, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get run CLI args from Results
1 participant
@umarcor