Move VHPIDIRECT related sources (implementation and example) to separate repo #606
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As commented in #603 (comment), this is a draft to remove VHDL and C sources related to VHPIDIRECT from this repository. The prosopal is as follows:
vunit/vhdl/data_types/src/external
tovunit/vhdl/data_types/src/api
:ghdl
.external_*-vhpi.vhd
.external_*-novhpi.vhd
andexternal_*-body.vhd
; rename toexternal_*_pkg_.vhd
.examples/vhdl/external_buffer
(remove it fromtests/acceptance/test_external_run_scripts.py
too).builtins._add_data_types
is simplified accordingly:{'string': ['path/to/custom/file'], 'integer': ['path/to/custom/file']}
is supported. The defaultvunit/vhdl/data_types/src/api/external_*_pkg_.vhd
is used when: any of the fields does not exist, isFalse
, or isNone
. Otherwise, the user-provided file is used.builtins._add_files
is enhanced in order to check if provided files actually exist.All the content that has been removed (the example,
*-vhpi.vhd
sources and subdirghdl
) is expected to be added to a newvunit/cosim
repository. In fact, this draft PR is a result of the discussion that is going on in #603.Note that this does not revert the 'external modes' feature introduced in
v4.3.0
. Files invunit/vhdl/data_types/*.vhd
are not modified at all. Hence, this is just a reorganization of the sources that moves specific implementations (e.g. GHDL's VHPIDIRECT) to a separate repository.