Satisfy some wemake rules #1546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamtheturtle
force-pushed
the
wemake
branch
3 times, most recently
from
43fc4fa to
1884025
Compare
This passes with `pip install wemake-python-styleguide` and: ``` flake8 --ignore=Q000,WPS305,I001,N818,D400,D200,D205,I005,WPS226,WPS326,WPS204,WPS323,WPS306,WPS115,S311,WPS300,WPS337,S101,WPS602,I003,DAR101,WPS436,WPS210,WPS460,WPS529,WPS201,WPS211,DAR201,S105,S106,RST301,WPS238,W503,WPS441,WPS214,WPS231,WPS213,WPS202,RST215,WPS432,WPS428,WPS237,D401,WPS218,I004,WPS336,WPS114,WPS110,WPS236,WPS520,WPS605,WPS450,WPS316,WPS334,DAR003,WPS429,DAR402,WPS510,S404,WPS462,WPS412,WPS410,WPS331 . ``` I chose to ignore rules which seemed to get in the way. Not putting this in CI as it is very slow.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1546 +/- ##
==========================================
+ Coverage 97.72% 97.84% +0.11%
==========================================
Files 71 71
Lines 5196 5193 -3
Branches 689 688 -1
==========================================
+ Hits 5078 5081 +3
+ Misses 83 77 -6
Partials 35 35
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes with
pip install wemake-python-styleguideand:I chose to ignore rules which seemed to get in the way. Not putting this in CI as it is very slow.