Skip to content

In TargetNameExist, capture the target name which already exists #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2019
Merged

In TargetNameExist, capture the target name which already exists #1131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b7e7d6
In TargetNameExist, capture the target name which already exists
adamtheturtle Dec 14, 2019
44881b6
Do not assume response.request has a json() field
adamtheturtle Dec 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/vws/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
"""
Custom exceptions for Vuforia errors.
"""

import json
from urllib.parse import urlparse

import requests
Expand Down Expand Up @@ -285,6 +287,15 @@ def response(self) -> Response:
"""
return self._response

@property
def target_name(self) -> str:
"""
The target name which already exists.
"""
response_body = self.response.request.body or b''
request_json = json.loads(response_body)
return str(request_json['name'])


class ImageTooLarge(Exception):
"""
Expand Down
1 change: 1 addition & 0 deletions tests/test_exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ def test_target_name_exist(
)

assert exc.value.response.status_code == codes.FORBIDDEN
assert exc.value.target_name == 'x'


def test_project_inactive(
Expand Down