Lab2 #1
Open
Lab2 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vloooo
reviewed
Jul 24, 2023
lab2/main.py
Outdated
Comment on lines
42
to
43
| most_popular_film = max(self.films, key=lambda x:x['popularity'])['original_title'] | ||
| return most_popular_film |
There was a problem hiding this comment.
Suggested change
| most_popular_film = max(self.films, key=lambda x:x['popularity'])['original_title'] | |
| return most_popular_film | |
| return max(self.films, key=lambda x:x['popularity'])['original_title'] |
vloooo
reviewed
Jul 24, 2023
lab2/main.py
Outdated
Comment on lines
38
to
39
| x = slice(3,19,4) | ||
| return self.films[x] |
There was a problem hiding this comment.
Suggested change
| x = slice(3,19,4) | |
| return self.films[x] | |
| return self.films[slice(3,19,4)] |
added 2 commits
July 28, 2023 17:25
everything done
everything done
vloooo
reviewed
Aug 1, 2023
lab2/main.py
Outdated
Comment on lines
14
to
15
| "accept": "application/json", | ||
| "Authorization": "Bearer eyJhbGciOiJIUzI1NiJ9.eyJhdWQiOiIzMTI3NGFmYTRlNTUyMjRjYzRlN2Q0NmNlMTNkOTZjOSIsInN1YiI6IjVkNmZhMWZmNzdjMDFmMDAxMDU5NzQ4OSIsInNjb3BlcyI6WyJhcGlfcmVhZCJdLCJ2ZXJzaW9uIjoxfQ.lbpgyXlOXwrbY0mUmP-zQpNAMCw_h-oaudAJB6Cn5c8" |
There was a problem hiding this comment.
double-quotes should be replaced with the single one
vloooo
reviewed
Aug 1, 2023
lab2/main.py
Outdated
Comment on lines
46
to
47
| return [f['original_title'] for f in self.films if word in f[ | ||
| 'overview']] |
There was a problem hiding this comment.
you shouldn't have splited it up for two lines
vloooo
reviewed
Aug 1, 2023
lab2/main.py
Outdated
Comment on lines
50
to
51
| answer_collect = frozenset(n for f in self.films for n in f['genre_ids']) | ||
| return answer_collect |
vloooo
reviewed
Aug 1, 2023
lab2/main.py
Outdated
Comment on lines
54
to
55
| result = [f for f in self.films if int(id_genre_del) not in f['genre_ids']] | ||
| return result |
vloooo
reviewed
Aug 1, 2023
vloooo
reviewed
Aug 1, 2023
lab2/main.py
Outdated
|
|
||
| def make_collection(self): | ||
| result_lst_dic = [self.make_dict(f) for f in self.films] # named tuple | ||
| print(result_lst_dic) |
vloooo
reviewed
Aug 1, 2023
lab2/main.py
Outdated
| @staticmethod | ||
| def csv_file_maker(coll_dict): | ||
| with open('lab2.txt', mode='w') as csv_file: | ||
| fieldnames = ['Title', 'Popularity', 'Score', 'Last_day_in_cinema'] |
vloooo
reviewed
Aug 1, 2023
| with open('lab2.txt', mode='w') as csv_file: | ||
| fieldnames = ['Title', 'Popularity', 'Score', 'Last_day_in_cinema'] | ||
| writer = csv.DictWriter(csv_file, fieldnames=fieldnames) | ||
|
|
vloooo
reviewed
Aug 1, 2023
lab2/main.py
Outdated
| from copy import deepcopy | ||
|
|
||
|
|
||
| # from collections import Counter |
There was a problem hiding this comment.
why do you commented it. you definitely use counter in further code
vloooo
reviewed
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lab 2 dict films