[MINOR] Add support for the remainder of .gitmodules attributes #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds all remaining .gitmodules "submodule" attributes to objects.Submodule: update, branch, ignore, shallow, fetchRecurseSubmodules (keyed as recurse) - Modifies read_gitmodules._read_gitmodules_file_content to use configparser instead of regex to simplify matching optional keys - Modifies any tests requiring direct Submodule instantiation, and adds a few extra arguments to test the extension
|
Came across this repository while perusing for a package to extend python-gitlab to include submodules. Needed access to other attributes like "submodule.[name].branch" and "submodule.[name].ignore", so I thought this would be a useful extension here. |
|
Hi, thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds all remaining .gitmodules "submodule" attributes to objects.Submodule: update, branch, ignore, shallow, fetchRecurseSubmodules (keyed as recurse)
Modifies read_gitmodules._read_gitmodules_file_content to use configparser instead of regex to simplify matching optional keys
Modifies any tests requiring direct Submodule instantiation, and adds a few extra arguments to test the extension