Fixed vbsp not loading game shader libraries #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for pushing this up! We've been using this in our codebase for about 5 months - we got the fix from you in the first place. Thought we'd hit a brick wall when we couldn't get lighting on surfaces using the SDK_* shaders, but this fixed it. I think it would save other teams some frustration in the future if it was included. |
untodesu
pushed a commit
to untodesu/refraction
that referenced
this pull request
May 18, 2020
TotallyMehis
added a commit
to zm-reborn/zmr-game
that referenced
this pull request
Jun 22, 2020
TotallyMehis
added a commit
to zm-reborn/zmr-game
that referenced
this pull request
Oct 2, 2020
untodesu
pushed a commit
to untodesu/refraction
that referenced
this pull request
Dec 22, 2020
wolfestridershooter
added a commit
to wolfestridershooter/source-sdk-2013-ce
that referenced
this pull request
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VBsp is not loading game shader libraries by default which results in custom lightmapped shaders to be unlit in-game. It can be fixed by calling IMaterialSystem::ModInit right after VBsp initialized the material system.