Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker and Docker Compose #630

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add Docker and Docker Compose #630

wants to merge 7 commits into from

Conversation

semenodp
Copy link
Collaborator

No description provided.

@semenodp semenodp requested a review from gfting June 24, 2020 21:39
@codeclimate
Copy link

codeclimate bot commented Jun 24, 2020

Code Climate has analyzed commit 06c34ce and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (0% is the threshold).

This pull request will bring the total coverage in the repository to 45.0% (0.0% change).

View more on Code Climate.

Copy link
Member

@leonm1 leonm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Nitpick: node is pinned to version 10, but the latest LTS is version 12

@github-actions github-actions bot added the approved Automatically added, do not manually add label Jun 25, 2020
@gfting
Copy link
Member

gfting commented Jun 30, 2020

This also looks good to me–I'm going to play around with the Docker build a bit more later today.

@semenodp
Copy link
Collaborator Author

This also looks good to me–I'm going to play around with the Docker build a bit more later today.

I think we also should add mongodb service here so we have db locally instead of writing to atlas, but not sure how useful would it be

@gfting
Copy link
Member

gfting commented Jul 3, 2020

This also looks good to me–I'm going to play around with the Docker build a bit more later today.

I think we also should add mongodb service here so we have db locally instead of writing to atlas, but not sure how useful would it be

I think we can make a separate issue for that, and go ahead and merge this in, then, if you're fine with that. Also, this is related to the GCP env var bug, since docker-compose was throwing an error for how I was setting up my gcp environment variables.

@leonm1
Copy link
Member

leonm1 commented Oct 22, 2020

@semenodp not sure if you're still interested in working on this, but I think that having mongo locally would be a huge boon for contributors. Would you be interested in setting that up?

@leonm1 leonm1 changed the base branch from staging to main October 22, 2020 11:22
@semenodp
Copy link
Collaborator Author

@semenodp not sure if you're still interested in working on this, but I think that having mongo locally would be a huge boon for contributors. Would you be interested in setting that up?

@leonm1 that should not take long to set up. When would you like for this to be done?

@leonm1
Copy link
Member

leonm1 commented Oct 22, 2020

At your leisure. I'm working through all the PRs to try and clean up this project and do some polish work. Thanks for offering!

@leonm1
Copy link
Member

leonm1 commented Oct 22, 2020

/rebase

@leonm1 leonm1 self-requested a review October 24, 2020 21:33
@semenodp
Copy link
Collaborator Author

semenodp commented Jan 22, 2021

@leonm1 I added mongodb to run in dev environment with docker-compose. Hardcoded the env variable just for sanity. Feel free to review and try locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Automatically added, do not manually add
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants