-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker and Docker Compose #630
base: main
Are you sure you want to change the base?
Conversation
Code Climate has analyzed commit 06c34ce and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (0% is the threshold). This pull request will bring the total coverage in the repository to 45.0% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Nitpick: node is pinned to version 10, but the latest LTS is version 12
This also looks good to me–I'm going to play around with the Docker build a bit more later today. |
I think we also should add mongodb service here so we have db locally instead of writing to atlas, but not sure how useful would it be |
I think we can make a separate issue for that, and go ahead and merge this in, then, if you're fine with that. Also, this is related to the GCP env var bug, since |
@semenodp not sure if you're still interested in working on this, but I think that having mongo locally would be a huge boon for contributors. Would you be interested in setting that up? |
At your leisure. I'm working through all the PRs to try and clean up this project and do some polish work. Thanks for offering! |
/rebase |
b9bf932
to
28bd0ea
Compare
@leonm1 I added mongodb to run in dev environment with docker-compose. Hardcoded the env variable just for sanity. Feel free to review and try locally. |
3ed9b7b
to
06c34ce
Compare
No description provided.