Dn reliable websockets #7 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rblumer4
reviewed
Oct 9, 2019
Comment on lines
1394
to
1395
| * Un | ||
| * s to all current subscriptions by closing the WebSocket to the Vantiq |
There was a problem hiding this comment.
accidental typo here, I think.
JakeSchmitz
approved these changes
Oct 18, 2019
| } | ||
|
|
||
| /**Acknowledge the receipt of a reliable message*/ |
There was a problem hiding this comment.
to be consistent with the other method comments this should be multiline:
/**
Acknowledge the receipt of a reliable message
*/
| this.accessToken = accessToken; | ||
| } | ||
| } | ||
| public void subscribe(String path, SubscriptionCallback callback, Map<String, Object> parameters) { |
There was a problem hiding this comment.
newline between the end of the class def and function def please
| @BeforeClass | ||
| public static void setUpIntgTest() throws Exception { | ||
| // Pull values from java properties, so the credentials are not checked in | ||
| server = System.getProperty("server"); | ||
| username = System.getProperty("username"); | ||
| password = System.getProperty("password"); | ||
|
|
||
| if(server == null || username == null || password == null) { |
There was a problem hiding this comment.
Leave this check in, just extend it to also check the token
| vantiq.authenticate(username, password, handler); | ||
| if (!username.equals("") && !password.equals("")) { | ||
| vantiq.authenticate(username, password); | ||
| } else { |
There was a problem hiding this comment.
This doesn't account for if the token wasn't specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for acknowledging events for reliable resources and create persistent/reconnectable subscriptions