Repository navigation
Replies: 13 comments 10 replies
|
Hi mike, I'm afraid a merge upstream is not possible. The Modbus layer was rewritten onto Home Assistant's shared Modbus connection, so there are too many changes across the whole repo. The only way I can imagine is replacing the old version completely with this one. I'm not sure callifo wants that, but he is welcome to take it. But Individual fixes that don't depend on the new base I am happy to send upstream as pull requests. Thanks :) |
|
Thank you for your answers. OK I kind of understand, if you changed to much underlaying code this is no simple thing you can add to the other integration. But I can give you some feedback. I have a Home Assistant at Home (Symo Gen24 12.0) and a Home Assistant at my company (Verto 30.0 Plus). The Home Assistant at the company is basically just for me to fool around as it does not do much. So I switched over to your integration to do some testing. Basically it is working but there are a few points :-)
|
|
Thank you for the testing 1, 2 and 4 are fixed in 1.1.2. After the update and a restart Home Assistant re-checks the statistics and the repair should clear on its own. If it stays, dismiss it rather than deleting the statistics. ... Two minimum SoC valuesThe inverter has two minimum-SoC settings, read by two different regulators, and the integration shows both:
Synchronisation goes one way: writing In practice: if you only use the inverter's own battery management (storage mode |
|
Thank you for the fixes. ad 1) is fixed for me So sorry to say but I don't have anything more to add. Everything works in my short period of testing :-) |
|
OK, some logs popped up. Just wanted to let you know if this is something to fix or just to ignore
|
|
You can ignore all 3.
|
|
Sure thing :) Could you check these sensors while the limit is active and take a screenshot of their history?
And the output from the inverter API with active limit (Please remove the IDs and Serial Numbers) http://IP-Inverter/api/components/inverter/readable Could you please create an issue next time? That way, I can keep better track of things. Thanks :) |
|
Hi @Varitras , looks like a lot of work has gone into the re-write. I only forked redpomodoro because he abandoned it and there were a bunch of people doing great fixes and updates all in isolation. I'm not a developer so the bulk of the effort has come from other contributors. As to avoid what happened with redpomodoro, you have longer term plans to maintain this version or get co-contributors to assist supporting? From a feature parity perspective, is that close to 1:1 now? It seems like getting everyone on the same page would be in the best interest moving forward, so I would be happy to attempt to re-direct users across to this fork going forward. |
|
Hi @callifo
Before the move (in my fork)
The move
Release to existing users
After the move
Entities that change from 0.3.4 to my version (entity ids and history stay) Display name changes
Not migrated yet (I fix this before the move)
State values
New entities (additions only)
|
|
One more thing I noticed while checking the migration: 0.3.4-rc2 ("fix capitals in translations") lowercased the data keys, and with them the unique ids of 28 sensor keys (inverter, meter and storage, e.g. AphA → apha, WHRtg → whrtg) and of the Inverter connection select. There is no migration for that, so anyone updating to rc2 gets new entities with new entity ids (often with "_2"), while the old ones stay behind orphaned with their history. Released as 0.3.4 like this, it would hit all your users. If we move to my code, that is already handled: my migration takes over both spellings, and where rc2 left the old entity beside the new one, the old one with its history is kept. If 0.3.4 comes out before that, I would keep the old keys (or add a unique id migration) before releasing. |
|
Great to here you working together :-) One thought from my side: HACS (soon to be the HA marketplace) still uses the repository from redpomodoro => Is it possible to let them exchange this with @callifo ´s repository? (Found it: https://hacs.dev/docs/publish/remove/ ) There are still opening new issues in the issue section of redpomodoro so I think people are not aware that this has been abandoned. |
|
https://github.com/orgs/home-assistant/discussions/5394 Do not uninstall the old repository. The Marketplace removes the integration’s configuration with it, and the update then has nothing to carry over. Instead, take a backup, replace the folder config/custom_components/fronius_modbus with the one from this release by hand, and restart. The Marketplace has no way yet to switch repositories, so it will not offer updates for this one (discussion). If you still run HACS, removing the repository there keeps the entry. This only affects people who switch the repo. |


Uh oh!
There was an error while loading. Please reload this page.
Hi, I just found your integration as a user of callifos fork.
Just some thoughts :-)
All reactions