[REF] l10n_mx: using code instaed color in onchange t#8500 #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luistorresm @moylop260 could you please check this.. |
split fields_view_get() and used an abstact mixin class in place of of FormatAddress [IMP] base: added a m2o field (ir.ui.view) on res.country to decide the layout of the form view to input addresses.
…ds inside the 'street' fields defined in base
… a list the city instead of a varchar field, when inputting addresses
…calized TIN number algorithm without forcing to prefix that number with the country code (which is weird for people).
When installing costa rican localization the partners titles has a wrong reference to base module that cause a warning messge in server log. In total the localization had 8 partners titles that not exists in base which was removed the reference and another 2 that exists in base but not had any difference. Courtesy of Vauxoo. Closes odoo#15495
…oo#205) Code extracted from saas-14: https://github.com/Vauxoo/odoo/blob/de38d0262b17f8e55926ac051f685afca2a82804/addons/l10n_mx/data/fiscal_position_data.xml#L114-L124 [IMP] l10n_mx: Added lost data to fiscal positions (Vauxoo#215) Fixed error "External ID not found in the system: l10n_mx.account_fiscal_position_foreign" while parsing /home/odoo/odoo-10.0/addons/l10n_mx/data/fiscal_position_data.xml:4
… on res.partner object
…ner form view *street fields should be editable only if we modify the main partner address *creating a res.city through the m2o should has default country and a domain
In base/res_partner.py, _fields_view_get calls _fields_view_get_address that could calls again _fields_view_get in case of address_view_id is specified. That leads to issue in base_address_city because the _fields_view_get_address method will replace two times the city field and then, we get a view with two city_id fields. see odoo#16870 for screenshots
…t.account issue#746 (Vauxoo#232) * [REF] l10n_mx: Onchange delete tag_ids when you change code in account.account issue#746 * [REF] l10n_mx: using pipe
… lang (Vauxoo#236) It was decided by Moylop to do this patch FIX odoo#18363 - [ ] TODO- Remove this ugly fix after issue odoo#18363 be solved Odoo Ticket 766.489
Like the address_format could be changed by each country, this method is required to append the field city_id in the views, to all country address formats. But if We need inherit the view to add a parameter in city or city_id, WE need overwrite this method. Now, with this change, We only inherit the view, and not all the method.
|
@moylop260 |
|
Could you remember the rational of this change, please? |
|
The main purpouse here is to avoid using the field 'color' to filter de tags. |
|
Yes, the main description has that sentence. |
|
The filter of the tags is made based in the color field, if the color changes then the method could not work as expected, so avoiding the use of that field may avoid that. |
|
Could you fix the conflicts, please? |
|
@nhomar |
|
Could you make a update of this branch, please? |
goliveirab
force-pushed
the
10.0-onchange-delete-tag_ids-issue772-goliveirab
branch
from
787fcef
to
84df3bf
Compare
|
@moylop260 could you please check it. |
|
Is there any changes or request about this? |
moylop260
reviewed
Sep 8, 2017
| # TODO: Remove this ugly fix, needed because es_419 lang is not | ||
| # supported by odoo yet. | ||
| # Remove this section after issue | ||
| # https://github.com/odoo/odoo/issues/18363 be solved. |
|
@goliveirab |
|
This PR has around of 8 months, and We do not have this problem. You think that We could close it? Regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isuue: https://github.com/Vauxoo/mexico/issues/772
Avoiding use of 'color' field to change the tags.
Result