[FIX] product: Price on pricelist with pricelists inside of it #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a you have a global pricelist and inside of it, you have an item 'applied on' 'Global' and a pricelist 'A' with product A, and another item also with 'applied on' 'Global' with a pricelist 'B' with the product B. And you make a sale order with the global pricelist and you add both products, the only product that is going to have the price set with the pricelist B or A it depends which item is first. With this change it will check in all items of the global pricelist until it find the price or it will set the price on the product. Also, adding the field `active` on the model `product.pricelist.item`.
After adding the method `_check_pricelist_rule` we need add the context and return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on
#372
Explain
When you have a global pricelist and inside of it, you have an item 'applied on' 'Global' and a pricelist 'A' with product A,
and another item also with 'applied on' 'Global' with a pricelist 'B' with product B.
And you make a sale order with the global pricelist and you add both products, the only product that is going to have the price set with the pricelist B or A it depends which item is first.
With this change, it will check in all items of the global pricelist until it finds the price or it will set the price on the product.
Notice
As this PR is being used in Stable branches not development pushes that have not been tested will done to this one.