Skip to content

Conversation

sb2702
Copy link
Contributor

@sb2702 sb2702 commented Feb 16, 2021

Putting the new docs code (From coder-docs) here

Story details: https://app.clubhouse.io/vectorly/story/3436

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #3436: Redo Website.

@unfoundbox
Copy link
Contributor

Mostly looks good. @sb2702

Penning down a few thoughts/suggestions -

  1. How about we change this - instead of showing the video-js tutorial thrice with different code snippets - put the standalone plugin snippet as hello world example and the basic web example - to show player skin is an add-on and not a must

https://gist.github.com/sb2702/47f473d8fd2ce743d5dd6e5873c1d1a3#file-index-html
https://gist.github.com/sb2702/5518427ffb4cce0efa9a36da40b00294#file-upscaling-hello-world-html

  1. How about a separate Events section under the Web section (for now, in the future more low-level APIs for mobile as well as video conferencing) for Upscaler events

  2. How about we host our Upscaler library using unpkg.com and put the actual CDN links - also put CDNs for other player libraries (daily.co uses unpkg)

  3. TODO - Update server-side demo and docs for webRTC

  4. Maybe use webrtcglossary.com for references than a private company's blog - could send a wrong signal
    or put the very same information on a notion doc

  5. We can have a Requirements (System & Bandwidth) section for conferencing or maybe for everything (web, mobile, conferencing)

  6. TODO - Update performance numbers for conferencing

  7. The conferencing section looks slightly dull. How about we add an architectural diagram (we can change few things from the web/mobile one) to catch some eyes

  8. IMO, the side-by-side demo looks much better (don't really know what's argument behind top-bottom, ik the BD folks have requested that) - can we change the three demos to reflect that

  9. Last but not least - original demo videos quality -> 360p if possible

Just thoughts, if we get time - we can discuss and priorities. I will take this up.

@sb2702
Copy link
Contributor Author

sb2702 commented Feb 22, 2021

For sure. If you can help out with some of these, that would be great!

Some priorities for this week:

  • Side by side demos
  • Doing demos at 360p
  • Performance numbers for conferencing

@unfoundbox unfoundbox mentioned this pull request Mar 16, 2021
Closed
@unfoundbox unfoundbox merged commit 50ac44a into master Mar 16, 2021
@unfoundbox
Copy link
Contributor

#2 is WIP. Blocking this PR. Will be merged in the next/smaller PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants