Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.72 2 sync #3406

Merged
merged 44 commits into from
Apr 11, 2024
Merged

0.72 2 sync #3406

merged 44 commits into from
Apr 11, 2024

Conversation

scudette
Copy link
Contributor

No description provided.

scudette and others added 30 commits April 11, 2024 09:52
This backs up volatile but critical information like hunts and client
info records.
The following rule matcher is valid:

```
detection:
   selection:
    field: null
```


https://github.com/SigmaHQ/sigma-specification/blob/main/Sigma_specification.md#special-field-values

Also support rules which omit the condition - while not strictly correct
they mean to match all the selection clauses.

This PR also removes the coercion to string of all the rule values and
use scope protocols instead. This results in a significant speedup as
well.
typo fixed.
resutls > results.
If an image does not contain a partition table, and it is a filesystem
(partition) image then we need to automatically add the image offset 0
When pipe() was used with parse_lines() a crash occured. This happened
because parse_lines() attempts to open files as gzip files first, then
reopen them again if that fails.

It is not possible to safely reopen an pipe though. This PR fixes the
crash and avoids opening the pipe as gzip first.
This lead to a phantom extra subdirectory added to each directory
listing under the mount point. This only happens when a mount remap is
added inside another remap (this does not normally happen in deaddisk
processing but happens in registry remapping)
artifacts/testdata/server/testcases/macos.out.yaml,
artifacts/testdata/server/testcases/macos.in.yaml and /artifacts/
and artifacts/definitions/MacOS/Forensics/FSEvents.yaml have received
updates to spelling of EnrtryPath to EntryPath.
When running large globs over the registry the accessor's performance
left a lot to be desired. This PR supercharges performance by using:

* Caching of registry keys and directory listings
* Lazy evaluations of value decoding
* Use of sync.Pool to reduce memory allocations
Also uploads() plugin now works in a notebook.
Since WSS connections are never re-established the nanny will timeout if
no messages were sent within the time (by default 10 min). This will
cause a hard exit.

---------

Co-authored-by: rob-wilco <140673290+rob-wilco@users.noreply.github.com>
…#3382)

This works transparently for encrypted containers providing the correct
server.config.yaml is used.

Also:

* Refactored raw_reg accessor to follow default key semantics properly.
* Refactored grpc client code to keep the caller's identity separated in
the client pool.
)

* Update ADSHunter to better account for ADS in root of drive
* Update tests Windows.NTFS.ADSHunter
dependabot bot and others added 14 commits April 11, 2024 09:54
A few users have commented to me that the download password setting is
unintuitive. Other settings in the form take effect once you click away
from the field and persist if the form disappears without closing. The
download password only updates with the close button.

To provide a visual cue and feedback, I added a Set button that changes
the password immediately. The button defaults to disabled until any
input is entered (including a blank password), and disables itself again
after submitting. I left the other setSetting calls in place as well.

In local testing, the password changes/button behavior worked as
expected. Collection downloads were encrypted using the saved password.

---------

Co-authored-by: Mike Cohen <mike@velocidex.com>
Also added multichoice parameter types.

CreateInitialNotebook will now block until all the cells are constructed
to ensure that the cells can not overwhelm the notebook workers. When an
artifact creates a large default notebook, the browser will attempt to
render each in parallel and this will initiate a worker update.
* Source() plugin did not support versions when reading from notebook
cells.
* Add Cell from Hunt regression - hunt GUI was modified
* Adding new secret did not allow adding templates
* ACE default UI elements were not set when user's GUI record was
missing.
For systems where DNF does not exist the following output is given back:

[
  {
    "Stdout": ""
  }
]

Therefore the switch statement is not proceeding with the b-variant
(yum). When filtering out via a WHERE statement this is done.
Replaced the old react-json-view with our own implementation:
* When arrays get too large, the display shows a modal box to allow
searching through them
* When json object is too large a button allowing modal to view the
whole object comfortably.
* New component is properly themeable using classes - no need for the
workaround for theming.
Add org_name field containing the Organization Name for use on Splunk

---------

Co-authored-by: Mike Cohen <mike@velocidex.com>
@CLAassistant
Copy link

CLAassistant commented Apr 10, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
7 out of 8 committers have signed the CLA.

✅ scudette
✅ mgreen27
✅ SBattaglia-R7
✅ rob-wilco
✅ KALRONG
✅ hendrkss
✅ hillu
❌ dependabot[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@scudette scudette merged commit 823d55c into v0.72 Apr 11, 2024
2 of 3 checks passed
@scudette scudette deleted the 0.72-2-sync branch April 11, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants