Skip to content

Conversation

cgutierr-zgz
Copy link
Contributor

The script setting serviceWorkerVersion was duplicated inside the body.

Status

READY

Description

Removes duplicate script

<script>
  // The value below is injected by flutter build, do not touch.
  const serviceWorkerVersion = null;
</script>

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@cgutierr-zgz cgutierr-zgz requested a review from a team as a code owner March 24, 2024 20:02
@cgutierr-zgz cgutierr-zgz changed the title Removes duplicate script from index.html chore: Removes duplicate script from index.html Mar 24, 2024
@tomarra
Copy link
Contributor

tomarra commented Mar 25, 2024

@erickzanardo any reason why we had this defined in the body as well? I just did made a new flutter app and in the web target it only has it defined in the head tag so this seems like something we maybe added on purpose?

@erickzanardo
Copy link
Member

@erickzanardo any reason why we had this defined in the body as well? I just did made a new flutter app and in the web target it only has it defined in the head tag so this seems like something we maybe added on purpose?

@tomarra I can't think in any reason. This seems mostly likely a mistake, makes no sense to have it duplicated like that as far as I can think.

@tomarra tomarra merged commit c46ee36 into VeryGoodOpenSource:main Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants