This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
feat!: add publishable flag #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzanardo
requested review from
felangel,
wolfenrain and
renancaraujo
as code owners
erickzanardo
commented
Nov 23, 2022
renancaraujo
previously approved these changes
Nov 24, 2022
|
Thoughts on also removing CHANGELOG and LICENSE when it is not publishable? |
Added! |
tool/generator/main.dart
Outdated
| await Future.wait( | ||
| Directory('patches').listSync().map( | ||
| (file) async { | ||
| await runGit( |
renancaraujo
previously approved these changes
Nov 29, 2022
felangel
reviewed
Nov 29, 2022
felangel
reviewed
Nov 29, 2022
renancaraujo
previously approved these changes
Nov 29, 2022
wolfenrain
previously approved these changes
Nov 29, 2022
erickzanardo
dismissed stale reviews from wolfenrain and renancaraujo
via
689c763
felangel
reviewed
Nov 29, 2022
Co-authored-by: Felix Angelov <felangelov@gmail.com>
felangel
previously approved these changes
Nov 29, 2022
felangel
reviewed
Nov 29, 2022
Co-authored-by: Felix Angelov <felangelov@gmail.com>
felangel
reviewed
Nov 29, 2022
Co-authored-by: Felix Angelov <felangelov@gmail.com>
|
FYI @wolfenrain @renancaraujo and @felangel This is ready for review (and probably merging) but we are holding this open until we have made the same change on the other bricks, so we can do the change on the CLI on a single task, lowering the chance that we forget to do the correct version publishing since this is a breaking change. |
felangel
approved these changes
Dec 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
HOLD
Description
Adds a publisable flag to the brick which will be used to decide if we will add the pana workflow and the publish_to field to the pubspec.
Fixes #22
Type of Change