Skip to content

Added and Updated HTML.md #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 23, 2024
Merged

Added and Updated HTML.md #88

merged 4 commits into from
Mar 23, 2024

Conversation

keiwsh
Copy link
Member

@keiwsh keiwsh commented Mar 22, 2024

As described. Tried to match the "layout" from already existing docs otherwise open to feedback.

@JDSherbert JDSherbert added the 👁️ Review: Required This PR is ready for review. label Mar 23, 2024
@JDSherbert JDSherbert added the 📖 Type: Content Edits to documentation/content. label Mar 23, 2024
JDSherbert
JDSherbert approved these changes Mar 23, 2024
View reviewed changes
Copy link
Collaborator

@JDSherbert JDSherbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JDSherbert
Copy link
Collaborator

@VerzatileDev just waiting for your sign-off dude

@JDSherbert JDSherbert added ✅ Review: Approved PR is approved and ready for merge. and removed 👁️ Review: Required This PR is ready for review. labels Mar 23, 2024
VerzatileDev
VerzatileDev requested changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@VerzatileDev VerzatileDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well written page, thank you for the contribution though please see the small nit-picking areas as changes.

Otherwise approved.

@VerzatileDev VerzatileDev added 📝 Review: Changes Requested PR Requires changes - feedback left. and removed ✅ Review: Approved PR is approved and ready for merge. labels Mar 23, 2024
@keiwsh
Copy link
Member Author

keiwsh commented Mar 23, 2024

Did the changes. Thanks for the feedback. 😃

VerzatileDev
VerzatileDev approved these changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@VerzatileDev VerzatileDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@VerzatileDev VerzatileDev added ✅ Review: Approved PR is approved and ready for merge. and removed 📝 Review: Changes Requested PR Requires changes - feedback left. labels Mar 23, 2024
@VerzatileDev VerzatileDev merged commit 893a25e into VerzatileDevOrg:main Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JDSherbert JDSherbert JDSherbert approved these changes

@VerzatileDev VerzatileDev VerzatileDev approved these changes

Assignees

@keiwsh keiwsh

Labels
✅ Review: Approved PR is approved and ready for merge. 📖 Type: Content Edits to documentation/content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keiwsh @JDSherbert @VerzatileDev