Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3 branch Dev_Issue3_TF #18

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Issue 3 branch Dev_Issue3_TF #18

merged 1 commit into from
Apr 6, 2023

Conversation

fitzcodes
Copy link
Collaborator

Created website with just html, following rules outlined in issue 3

@fitzcodes fitzcodes requested a review from a team April 3, 2023 22:51
@netlify
Copy link

netlify bot commented Apr 3, 2023

Deploy Preview for unrivaled-treacle-6c0174 ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/unrivaled-treacle-6c0174/deploys/642b59a40c0899291dc7e8bb
😎 Deploy Preview https://deploy-preview-18--unrivaled-treacle-6c0174.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fitzcodes fitzcodes mentioned this pull request Apr 3, 2023
Closed
@axecopfire
Copy link
Member

axecopfire commented Apr 5, 2023

I've already added to the course feedback doc, that the issues don't call out that each week should be building on previous weeks. So, this is your opportunity to start building the HTML to the Portfolio you designed in a previous week. This HTML does satisfy the Standards how they're written, which is why I'm giving it an approval. But we're expecting the course to be an implementation of your own design as opposed to solving each issue in isolation. Reach out if you have any questions.

Also, please link the issue number in project description. So, like solves #3

@fitzcodes
Copy link
Collaborator Author

Also, please link the issue number in project description. So, like solves #3

Do you mean for the netlify side of things?

So, this is your opportunity to start building the HTML to the Portfolio you designed in a previous week

Ah okay. Makes sense. As I work the next issue with the CSS, I'll update the HTML for the portfolio scaffold and ensure it also hits the requirements. For what I have planned it won't be a problem.

@fitzcodes fitzcodes merged commit ee7db64 into main Apr 6, 2023
@fitzcodes fitzcodes deleted the Dev_Issue3_TF branch April 6, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants