Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-5.9] LOG-4739: Enhance Vector kubernetes_logs to support include_paths_glob_patterns #167

Merged

Conversation

syedriko
Copy link

Add an option to vector kubernetes_logs source to allow configuration of files to include so the collector can be configured with explicit sources that map to CLF inputs which include/exclude files by namespace.
The name of the new config variable is include_paths_glob_patterns, it is a list of glob patterns and defaults to "**/*", meaning "include everything".

JIRA: https://issues.redhat.com/browse/LOG-4739

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 17, 2023

@syedriko: This pull request references LOG-4739 which is a valid jira issue.

In response to this:

Add an option to vector kubernetes_logs source to allow configuration of files to include so the collector can be configured with explicit sources that map to CLF inputs which include/exclude files by namespace.
The name of the new config variable is include_paths_glob_patterns, it is a list of glob patterns and defaults to "**/*", meaning "include everything".

JIRA: https://issues.redhat.com/browse/LOG-4739

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link

openshift-ci bot commented Nov 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, syedriko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d749c76 into ViaQ:release-5.9 Nov 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants