Skip to content

Avoid allocating new string when output_postamble is blank #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 3, 2024
Merged

Avoid allocating new string when output_postamble is blank #1911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9462fc5
Avoid allocating new string when output_postamble is blank
mitchellhenke Nov 13, 2023
ed8d7b9
Merge branch 'main' into avoid-duplicating-to-concat-empty-string
joelhawksley Jan 3, 2024
aa4a4a7
Apply suggestions from code review
joelhawksley Jan 3, 2024
e2e06a9
Merge branch 'main' into avoid-duplicating-to-concat-empty-string
joelhawksley Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ nav_order: 5

*Olle Jonsson*

* Avoid duplicating rendered string when `output_postamble` is blank.

*Mitchell Henke*

## 3.8.0

* Use correct value for the `config.action_dispatch.show_exceptions` config option for edge Rails.
Expand Down
7 changes: 6 additions & 1 deletion lib/view_component/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,12 @@ def render_in(view_context, &block)
before_render

if render?
render_template_for(@__vc_variant).to_s + output_postamble
# Avoid allocating new string when output_postamble is blank
if output_postamble.blank?
render_template_for(@__vc_variant).to_s
else
render_template_for(@__vc_variant).to_s + output_postamble
end
else
""
end
Expand Down