Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout broken on iOS safari #340

Closed
moisout opened this issue Feb 3, 2021 · 0 comments · Fixed by #508
Closed

Layout broken on iOS safari #340

moisout opened this issue Feb 3, 2021 · 0 comments · Fixed by #508
Labels
bug Something isn't working UI UI-Related changes or features

Comments

@moisout
Copy link
Member

moisout commented Feb 3, 2021

Currently, the layout of some pages is broken in ios safari.

Originally posted by @Mennaruuk in #294 (comment)

I share your feelings about the appearance. I think Invidious looks too simple, and your take on this with ViewTube is awesome. I love the look of VT!

A couple of things I noticed on the dev page:

  • This is how the Settings page currently looks like on my smartphone:
    F74D432F-CB48-4B2A-945D-A11F8096ED36
    Also the About page:
    85998AB3-8845-4345-9022-DFC0D5CE42E7

  • The text to the right of the checkboxes for instance selection creates excessive space where I have to swipe right to see everything. Also, there is no button to return to homepage after choosing an instance (beside refreshing). Clicking the browser’s back button returned me to the site I was on before ViewTube:
    9871DFFD-FA18-44B4-92FF-9A0425ADF5B5

Thank you for this great site! 🙏
@moisout moisout added bug Something isn't working UI UI-Related changes or features labels Feb 7, 2021
@moisout moisout mentioned this issue Mar 28, 2021
Merged
moisout added a commit that referenced this issue Mar 29, 2021
@moisout
🐛 Bugfixes (#508)
9614e13 
Resolves #65
Resolves #66
Resolves #67
Resolves #70
Resolves #340

- Add proxy url to all images
- Disable scrolling when a popup is open
- Fix input field styles for chrome autofill
- Fix disabled subscribe button being reachable with tab
- Fix duplicate and missing meta tags
- Reduce build size by removing unused dependency
- Fix too wide icon on ios
- Improve subscription job
- Fix settings layout
- Fix about page layout

* 🐛 add missing imgProxyUrl

* 💚 update deployment config

* 🚧 begin on replacing nuxt event bus

* 🐛 replace nuxt event bus with store

* 🐛 remove clickaway directive

* 🐛 fix chrome autofill makes input field white

* 🐛 fix selectable disabled subscribe button

* 🐛 fix meta tags

* 🐛 fix duplicate meta tags

* 🐛 improve docker delete command

* ⚰️ remove unused dashjs

* ⚰️ comment unnecessary variables

* 🐛 fix too wide icon on ios

* ⚡️ improved subscription job efficiency

* 💄 fix logo width in desktop mode

* 🐛 add missing proxy to channel page

* 💄 fix channel links styling

* 👽 fix channel api

* 🐛 fix links directive

* 🐛 fix license styling

* 🐛 fix settings layout

* 🐛 fix about page layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working UI UI-Related changes or features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfixes ViewTube/viewtube
1 participant
@moisout