Joel Jacob #1
Joel Jacob #1
Conversation
| @@ -0,0 +1,30 @@ | |||
| //Declare and initilize variables | |||
| let howOldAreYou; | |||
There was a problem hiding this comment.
Normally there's no reason to initialize variables in advance, you can simply initialize them down the line where you use it (line 15)
| @@ -0,0 +1,30 @@ | |||
| //Declare and initilize variables | |||
| let howOldAreYou; | |||
| let invalidInput; | |||
There was a problem hiding this comment.
This is not needed as I will comment below
| //Declare and initilize variables | ||
| let howOldAreYou; | ||
| let invalidInput; | ||
| let Age; |
There was a problem hiding this comment.
All JS variables should use camelCasing
| let howOldAreYou; | ||
| let invalidInput; | ||
| let Age; | ||
| let approvedAge = 21; |
There was a problem hiding this comment.
Variables that do not change should always be a const
| let approvedAge = 21; | |
| const approvedAge = 21; |
There was a problem hiding this comment.
Unrelated, minimumAge is a more descriptive variable name
| const WELCOME_MESSAGE = `Welcome To The Kosher Wine Cellar! | ||
| You must be over 21 years to purchase on our site!`; |
There was a problem hiding this comment.
Since you've defined the minimum age above (approvedAge) you can now use it inside the message
| const WELCOME_MESSAGE = `Welcome To The Kosher Wine Cellar! | |
| You must be over 21 years to purchase on our site!`; | |
| const WELCOME_MESSAGE = `Welcome To The Kosher Wine Cellar! | |
| You must be over ${approvedAge} years to purchase on our site!`; |
|
|
||
| console.log(typeof Age); | ||
|
|
||
| invalidInput = isNaN(Age); |
There was a problem hiding this comment.
This is unnecessary
| invalidInput = isNaN(Age); |
|
|
||
| invalidInput = isNaN(Age); | ||
|
|
||
| Age =Number(Age); |
There was a problem hiding this comment.
| Age =Number(Age); | |
| age = Number(age); |
You can also do
age = +age;
Using the plus operator next to a string will convert it to a number
|
|
||
| Age =Number(Age); | ||
|
|
||
| console.log(typeof Age); |
There was a problem hiding this comment.
In the future, submit your code without loggin
|
|
||
| console.log(typeof Age); | ||
|
|
||
| if (invalidInput) { |
There was a problem hiding this comment.
Instead of using a separate variable "invalidInput" you can inline it as such
| if (invalidInput) { | |
| if (isNaN(age)) { |
| throw 'INVALID_INPUT'; | ||
| } | ||
|
|
||
| if (Age >=approvedAge) { |
There was a problem hiding this comment.
Code clarity dictates symmetric spacing
| if (Age >=approvedAge) { | |
| if (age >= approvedAge) { |
1 participant
No description provided.