Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README: old subcommand name #57

Merged
merged 1 commit into from Oct 11, 2018
Merged

Fix README: old subcommand name #57

merged 1 commit into from Oct 11, 2018

Conversation

tyru
Copy link
Contributor

@tyru tyru commented Oct 10, 2018

No description provided.

@blueyed blueyed merged commit a4ed5e6 into Vimjas:master Oct 11, 2018
@blueyed
Copy link
Member

blueyed commented Oct 11, 2018

Thank you!

@blueyed
Copy link
Member

blueyed commented Oct 11, 2018

@tyru
Well, the command is "write_coverage" actually?!
Will revert it shortly.
/me shouldn't have ignored all the test failures.. :D

@blueyed
Copy link
Member

blueyed commented Oct 11, 2018

Force-pushed HEAD~1..

@tyru
Copy link
Contributor Author

tyru commented Oct 11, 2018

Really? The one which I installed it from pip is write-coverage.
I found this because vital.vim's CI failed.
vim-jp/vital.vim#608
I didn't check that the latest (repository) changes the command name to write_coverage.

@tyru
Copy link
Contributor Author

tyru commented Oct 11, 2018

Hmm, the latest one seems write-coverage.
am I missing something?

$ git clone {this repo}
$ cd covimerage
$ pip3 install .

$ covimerage write-coverage
Not writing coverage file: no data to report!
Error: No data to report.

$ covimerage write_coverage
Usage: covimerage [OPTIONS] COMMAND [ARGS]...
Try "covimerage -h" for help.

Error: No such command "write_coverage".

@blueyed
Copy link
Member

blueyed commented Oct 11, 2018

Oh.
This is due to click 7: pallets/click@5d1df0e

I suggest pinning it to <7 for now, will create a bugfix release shortly.

@blueyed blueyed mentioned this pull request Oct 11, 2018
blueyed added a commit to blueyed/covimerage that referenced this pull request Oct 11, 2018
@tyru
Copy link
Contributor Author

tyru commented Oct 11, 2018

Well, I understand that write_coverage is the right command name. 53d0968
So we just have to revert write-coverage to write_coverage, and wait until you upload the latest one to pypi, okay? :)

@blueyed
Copy link
Member

blueyed commented Oct 11, 2018

Yes, let's keep the old name for compatibility.
I've released 0.1.2 now: https://pypi.org/project/covimerage/.

Thanks for the report, and sorry for the confusion.. :)

@tyru
Copy link
Contributor Author

tyru commented Oct 11, 2018

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants