Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PT-6925: Support for Apps inside modules #2574

Merged
merged 12 commits into from
Nov 15, 2022
Merged

PT-6925: Support for Apps inside modules #2574

merged 12 commits into from
Nov 15, 2022

Conversation

OlegoO
Copy link
Contributor

@OlegoO OlegoO commented Nov 8, 2022

Description

feat: Add support for Apps inside VC modules.

References

QA-test:

Jira-link:

Artifact URL:

/// Path to App content in the module. By default Content/{moduleApp.Id}
/// </summary>
public string ContentPath { get; set; }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove empty line

</div>
<div class="links-menu__list">
<div class="links-menu__links">
<a ng-repeat="appItem in menu.apps" target="_blank" href="{{appItem.relativeUrl}}" va-permission="{{appItem.permission}}" class="links-menu__link links-menu__link--active" >

Check warning

Code scanning / CodeQL

Potentially unsafe external link

External links without noopener/noreferrer are a potential security risk.
Copy link
Contributor

@tatarincev tatarincev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure what you want to use this icon platform_app.svg for platform APP?

@sonarcloud
Copy link

sonarcloud bot commented Nov 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

4.2% 4.2% Coverage
0.0% 0.0% Duplication

@OlegoO OlegoO merged commit b4cafbe into dev Nov 15, 2022
@OlegoO OlegoO deleted the feat/PT-6925-apps branch November 15, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants