Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Add "real" multi-component leaf/plant model example #33

Closed
ashiklom opened this issue Apr 17, 2023 · 1 comment
Closed

[REVIEW] Add "real" multi-component leaf/plant model example #33

ashiklom opened this issue Apr 17, 2023 · 1 comment

Comments

@ashiklom
Copy link

The current multi-model example in Model-Switching (https://vezy.github.io/PlantSimEngine.jl/stable/model_switching/) is a bit esoteric. Unless you're good at software engineering already (which is not the intended audience of this package), that makes it a bit tricky to see the value of the approach.

I suggest including a more real example -- even if it's a really basic one.

openjournals/joss-reviews#5371

@ashiklom ashiklom changed the title [Review] Add "real" multi-component leaf/plant model example [REVIEW] Add "real" multi-component leaf/plant model example Apr 17, 2023
VEZY added a commit that referenced this issue Apr 26, 2023
VEZY added a commit that referenced this issue Apr 27, 2023
Improve writing and add info about parallel warning #33
@VEZY
Copy link
Member

VEZY commented Apr 27, 2023

OK these last commits should do it. Let me know if you have any other request or if that's not clear enough.

@VEZY VEZY closed this as completed Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants