-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate only one build target for main and test scope #550
Conversation
18b4204
to
f6b7bd0
Compare
4f06f22
to
13b8d23
Compare
2752428
to
72935e3
Compare
@@ -255,13 +259,29 @@ object Build { | |||
(mainBuild, extraBuilds) | |||
} | |||
|
|||
def doPostProcess(build: Seq[Build], scope: Scope) = build.collect { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we ignore errors from post process?
Also a small nit, you can combine collect
and map
into one call
0029cd8
to
2c9aada
Compare
2c9aada
to
ec3bd8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still unsure what these changes do precisely, but if the CI is green, I guess it's fine.
|
This works only if no test-specific options are enabled, right? (like |
4717114
to
180cc1b
Compare
Ok, I saw the test options taken into account when computing the project hash… :) |
No description provided.