Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate zip supported by sdk #609

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Generate zip supported by sdk #609

merged 1 commit into from
Feb 3, 2022

Conversation

lwronski
Copy link
Contributor

@lwronski lwronski commented Feb 2, 2022

  • SDKMAN requires that a package has a top-level directory after extraction, and a bin folder directly underneath it - more info here
  • generate os packages only when release CI is running

alexarchambault
alexarchambault approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check that it works fine on the CI by… maybe temporarily reverting the SHOULD_PUBLISH stuff you added in .github/workflows/ci.yml?

.github/scripts/generate-os-packages.sh Outdated
sdkDirectory="scala-cli-x86_64-pc-win32-sdk"
binName="scala-cli.exe"
else
echo "Unrecognized operating system: $OSTYPE" 1&2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo "Unrecognized operating system: $OSTYPE" 1&2
echo "Unrecognized operating system: $OSTYPE" 1>&2

@lwronski
Copy link
Contributor Author

lwronski commented Feb 3, 2022 •
edited
Loading

Did you check that it works fine on the CI by… maybe temporarily reverting the SHOULD_PUBLISH stuff you added in .github/workflows/ci.yml?

Yes, I tested it using this commit. And here are generated artifacts by CI.

@lwronski lwronski force-pushed the sdk-support branch 2 times, most recently from 14e69b5 to 88a424d Compare February 3, 2022 11:01
@lwronski lwronski merged commit b3dd2cd into master Feb 3, 2022
@lwronski lwronski deleted the sdk-support branch February 7, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarchambault alexarchambault alexarchambault approved these changes

@romanowski romanowski romanowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lwronski @romanowski @alexarchambault