Skip to content
This repository was archived by the owner on Aug 17, 2021. It is now read-only.

Conversation

fredriks
Copy link
Contributor

No description provided.

@DanielaValero
Copy link

Hello,

Is there a plan to have this merged and published any time soon? Would be good to be able to have commonJS support

@mtrias
Copy link
Contributor

mtrias commented Mar 14, 2017

Sure!... i'm glad to merge. Can someone please fix the conflicts first?

@TheSharpieOne
Copy link
Contributor

require('angular-recaptcha'); and import 'angular-recaptcha'; currently work just fine.
All this PR does is give you the ability to set variables with the module name so you can give it to angular instead of having to use a string.

@fredriks
Copy link
Contributor Author

Conflicts resolved!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.262% when pulling 4312d0f on fredriks:master into a853512 on VividCortex:master.

@mtrias mtrias merged commit 26d3111 into VividCortex:master Mar 14, 2017
@mtrias
Copy link
Contributor

mtrias commented Mar 14, 2017

Thanks @fredriks!

@DanielaValero
Copy link

Hi! did not see the notifications about the open tasks for this. Otherwise also would have helped. I am glad that you guys got it merged! Thanks!

@Lars-Weber
Copy link

Hey @mtrias ,

thanks so much for dealing with this so quickly!

Could you publish the 4.0.4 release on npm?

@mtrias
Copy link
Contributor

mtrias commented Mar 17, 2017

Doh... always forget this. We need a script :P

It's done now!

@Lars-Weber
Copy link

np! :-)

Thanks so much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants