This repository was archived by the owner on Aug 17, 2021. It is now read-only.
Added support for the new Invisible reCaptcha badge attribute and execute() API method. #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/directive.js
Outdated
| lang: scope.lang || attrs.lang || null, | ||
| tabindex: scope.tabindex || attrs.tabindex || null, | ||
| size: scope.size || attrs.size || null, | ||
| badge: scope.badge || attrs.badge || null, |
|
Thank you for your contribution! Is anyone else interested in this PR to be merged? If yes, then I'd appreciate someone to test this, confirm that it works, and code review. |
|
@mtrias it looks good to me and I've been able to use the invisible recaptcha (not used in production). |
iambrosi
suggested changes
Apr 18, 2017
| provider.setLang = function(lang){ | ||
| config.lang = lang; | ||
| }; | ||
| /** |
There was a problem hiding this comment.
Nitpick: Can you add an empty line between provider methods?
src/service.js
Outdated
| config.lang = lang; | ||
| }; | ||
| /** | ||
| * Sets the reCaptcha badge position which will be used by default is not specified in a specific directive instance. |
There was a problem hiding this comment.
Nitpick 2:
-...by default is not specified...
+...by default if not specified...
src/service.js
Outdated
| /** | ||
| * Sets the reCaptcha badge position which will be used by default is not specified in a specific directive instance. | ||
| * | ||
| * @param lang The reCaptcha badge position. |
There was a problem hiding this comment.
The parameter name is wrong.
iambrosi
approved these changes
Apr 24, 2017
|
Thanks @bjornlaurell !! |
|
Tagged as 4.1.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the following issue: #186