Fix: Error from no-content responses #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion from EntityUtils solution: for empty response log "".
Codecov Report
@@ Coverage Diff @@
## master #304 +/- ##
=========================================
Coverage 90.00% 90.00%
- Complexity 1438 1439 +1
=========================================
Files 249 249
Lines 3943 3943
Branches 191 192 +1
=========================================
Hits 3549 3549
Misses 343 343
Partials 51 51
|
|
Hi @vyj7 - this looks like it ought to fix the issue, however without a Unit Test there's no way to set up a regression to validate that it won't happen again in the future - can you please add a unit test to this PR to make sure it doesn't toss the exception anymore? Thanks |
|
@slorello89 I have added UT for LoggingUtils Class |
slorello89
approved these changes
Oct 5, 2020
|
@yallen011 - I'll leave this for you to merge but it looks all good in my book! |
martyndavies
added
the
Hacktoberfest-accepted
yallen011
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Logging an empty response was throwing IllegalArgumentException from EntityUtils
Solution: For an empty response log nothing by adding a Null check
Contribution Checklist