Skip to content

Conversation

maxkahan
Copy link
Contributor

@maxkahan maxkahan commented Apr 13, 2023

The numbers api now uses header authentication instead of query parameter authentication.

Have added a type hint to the response to allow for easier debugging

Blackened the file

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023

Codecov Report

Merging #255 (049f087) into main (d338f37) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #255   +/-   ##
=======================================
  Coverage   97.25%   97.25%           
=======================================
  Files          20       20           
  Lines         728      729    +1     
=======================================
+ Hits          708      709    +1     
  Misses         20       20           
Impacted Files Coverage Δ
src/vonage/client.py 96.29% <100.00%> (+0.01%) ⬆️
src/vonage/number_management.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maxkahan maxkahan merged commit f4ebdfa into main Apr 14, 2023
@maxkahan maxkahan deleted the numbers-auth branch April 14, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants