Fix header logo position

[bengott]

logo position was wonky between 30em and 40em screen widths -- noticed it on my phone in landscape orientation

Here's what it looks like on crater.io (where I also submitted a PR)

Also, it seems kind of weird to have the source scss files and the resulting CodeKit-generated css files all in source control. I guess there weren't any good Sass packages for Meteor back when Sacha first wrote Telescope? Since this was such a small change, I just manually edited both the source _header.scss and resulting screen.css files. I don't have CodeKit (running Linux here), and I didn't want to regenerate the css with a different Sass preprocessor and introduce a bunch of trivial changes.

Cheers!
Ben

[SachaG]

Thanks! And yeah, I guess the outputted CSS could be omitted from source control. Which SASS package would you recommend? This one? https://github.com/particle4dev/meteor-sass/

[bengott]

To be honest, I've never used Sass in a Meteor project, so I don't know. :/
I just figured that because there are several packages available, there must be a way to do it within the Meteor build process. I posted a question in the meteor-talk group to solicit some recommendations:
https://groups.google.com/forum/#!topic/meteor-talk/FD1PmAAFDaQ

[SachaG]

Thanks, let's see what kind of replies you get :)

[bengott]

Only got one reply so far, but it looks like the package Julian Ćwirko suggested has the most downloads and activity on Atmosphere/GitHub:
http://atmospherejs.com/fourseven/scss

I might take a stab at integrating it into Telescope, but I have a feeling there will be issues. I'll let you know how it goes...

Off the top of your head, do you know if you make use of @extend or Sass 3.3 features like list-maps and suffix selectors in your scss files? Incorrect @extend compilation seems to be the biggest issue in libsass:
sass/libsass#146

[SachaG]

Extend maybe yes, but not the other ones. Now I do remember that this was
the reason I'm not using lib-sass, I wasn't sure if it'd be compatible with
my code.

On Thu, Sep 11, 2014 at 1:58 PM, Ben Gott notifications@github.com wrote:

Only got one reply so far, but it looks like the package Julian Ćwirko
suggested has the most downloads and activity on Atmosphere/GitHub:
http://atmospherejs.com/fourseven/scss

I might take a stab at integrating it into Telescope, but I have a feeling
there will be issues. I'll let you know how it goes...

Off the top of your head, do you know if you make use of @extend or Sass
3.3 features like list-maps and suffix selectors in your scss files?
Incorrect @extend compilation seems to be the biggest issue in libsass:
sass/libsass#146 sass/libsass#146

—
Reply to this email directly or view it on GitHub
https://github.com/TelescopeJS/Telescope/pull/380#issuecomment-55219499.

[bengott]

Oh well. There are worse problems to have, I guess. I suppose that if someone makes big CSS changes and doesn't use CodeKit, they could use another compiler and just commit everything (scss and css files). Then you could regenerate and replace the css files before you merge in the changes. This probably doesn't happen very often, so no big deal. I wouldn't recommend removing the generated css files from source control unless they can be automatically generated by the build process, though. Without the css files, users would have to generate them as a separate step before running the app, which might involve installing Ruby, etc.

[SachaG]

I agree. I would be happy to use libsass if it works though, as always PRs are welcome :)