Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Shallow Clones instead of complete Clones to speed up :BundleInstall #335

Closed
wants to merge 1 commit into from

Conversation

javier-lopez
Copy link

I think most people would prefer to only download the latest version of vim plugins:

http://mortalpowers.com/news/speed-up-git-clone-with-shallow-clones

@@ -222,7 +222,7 @@ func! s:sync(bang, bundle) abort
let get_current_sha = g:shellesc_cd(get_current_sha)
let initial_sha = s:system(get_current_sha)[0:15]
else
let cmd = 'git clone --recursive '.shellescape(a:bundle.uri).' '.shellescape(a:bundle.path())
let cmd = 'git clone --dept=1 --recursive '.shellescape(a:bundle.uri).' '.shellescape(a:bundle.path())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the fact that I don't see a PR accepted since months except for broken link. I think It should be

--depth=1

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both work vheon =) (however probably it would be more correct --depth)

@MarcWeber
Copy link

note: google git accounts did not support shallow clones (See vim-addon-manager implementation which takes care of this all already)

@MarcWeber
Copy link

Thus using VAM's vundle emulation would provide an immediate fix

@jdevera
Copy link
Contributor

jdevera commented Feb 12, 2014

Although it makes sense to have an option to turn this on, it probably should not be the default, as it might cause problems with some git servers, as @MarcWeber pointed out.

@jdevera
Copy link
Contributor

jdevera commented Feb 12, 2014

Thanks for the PR! Please see #28 on why we cannot merge this PR. Please join the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants