Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put sympy back on the menu #1440

Merged
merged 4 commits into from
Oct 2, 2022
Merged

Put sympy back on the menu #1440

merged 4 commits into from
Oct 2, 2022

Conversation

lyxal
Copy link
Member

@lyxal lyxal commented Sep 13, 2022

Under a very restricted system though

  • Unicode is normalized as python normalizes it to avoid anything funky there
  • No "'{}_ or backtick in expressions
  • No decimals with letters on either side
  • No runs of characters longer than 1
  • Some remaining characters are converted to helpful sympy functions

Closes #867

Under a very restricted system though

- No \"'{}_ or backtick in expressions
- No decimals with letters on either side
- No runs of characters longer than 1
- Some remaining characters are converted to helpful sympy functions
@lyxal lyxal added PR: Bug Fix PR only tag - a PR that is fixing a bug/issue PR: Careful Review Required PR only tag - PRs that handle issues tagged difficulty very hard sympy's fault labels Sep 13, 2022
Copy link
Member

@ysthakur ysthakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a symp for sympy and this PR lgtm overall (although I admit I don't totally understand the sympy exploits), but just one small thing

vyxal/helpers.py Outdated Show resolved Hide resolved
@lyxal lyxal requested a review from ysthakur September 18, 2022 11:56
Copy link
Contributor

@Steffan153 Steffan153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay well we'll see how many ACEs this has.

@lyxal lyxal dismissed ysthakur’s stale review September 24, 2022 01:27

Them changes were made you nerd.

@lyxal lyxal merged commit 333834a into main Oct 2, 2022
@lyxal lyxal deleted the make-sympy-great-again branch October 2, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix PR only tag - a PR that is fixing a bug/issue PR: Careful Review Required PR only tag - PRs that handle issues tagged difficulty very hard sympy's fault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix ACE in make_expression
3 participants