Jimmy/initial setup #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add logger - add logic for retrieving a yml file from a user config - TODO: sending emails, creating edit link
- environment variables for the email - generate edit link based on user config
Jimmyj30
force-pushed
the
jimmy/initial_setup
branch
from
4e7683d
to
bb4f142
Compare
- edit comments
ben-z
reviewed
Oct 22, 2023
|
We should also add in error reporting like what we have in the Discord bot: https://github.com/WATonomous/discord-provisioner-bot/blob/801784a61d4499e2d3646898ba38d8fa33dbb97a/main.py#L13-L27 You can create a new Sentry project via IaC and pass it to the deployment: https://github.com/WATonomous/infra-config/blob/a2ad9534ce7e83179a07c7d65fbb608f0bde7e17/sentry/main.tf. But it's also useful to try it out manually first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial setup/"boilerplate" code for the user config lookup functionality
Seems to work? I guess we can address formatting the email nicely, as well as finding (and fixing) bugs next?