i729 Ignore Contributions when determining if an Asset is missing child records #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PbcoreXmlParser calls the PBCoreXMLMapper directly (which was already counting an Asset's children), meaning we were setting the attr twice for no reason
…cords This is ultimately because there is a possibility that the creation of all of an Asset's Contributions could be skipped, which would significantly throw off the count for comparison.
bkiahstroud
changed the title
aprilrieger
approved these changes
Aug 2, 2023
alishaevn
approved these changes
Aug 2, 2023
orangewolf
approved these changes
Aug 3, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a possibility that the creation of all of an
Asset'sContributions could be skipped, which would significantly throw off the count for comparison.It has been decided to ignore
Contributions entirely when it comes to validatingAssets for missing children, at least untilContributioncreation is consistent.