Add UnicodePlots to dependencies #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce the extension for the unicode_ plotting methods is not actually loaded
|
The julia 1.9 tests start dying here because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
ExtendableFEMBase.jl's update to0.8.0moved theunicode_*plotting functions into its own extension, we either need to guard their appearances in the code against the extension being loaded or just outright addUnicodePlotsto the dependencies.Since it seems from the examples and hard-coded usage in the
solvecall that we'd want to have these included by default, I took the liberty of simply adding the package to the dependencies.I also updated the
compats to include the latest minor version ofExtendableFEMBase.