Skip to content

Fix arg-dependent case of BilinearOperatorDG assemble! #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025
Merged

Fix arg-dependent case of BilinearOperatorDG assemble! #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4def96c
fixed one case of assembly! of BilinearOperatorDG into matrix
chmerdon Apr 16, 2025
ad18a79
version bump and updated changelog
chmerdon Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,24 @@
# CHANGES

## next version
## v1.0.1 April 16, 2025

## v1.0.0 April 11, 2025
### Fixed

- assemble! of (args-dependent) BilinearOperatorDG now works



## v1.0.0 April 14, 2025

### Added

- new example on coupled Stokes-Darcy (Example264)

### Added
### Changed

- example `Example301` now also demonstrates a nonlinear problem solved by an iterative linear solver
with preconditioning.

### Changed

- `solve` uses now the residual equation for the linear systems
- facelift `Example250`.

Expand Down
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "ExtendableFEM"
uuid = "a722555e-65e0-4074-a036-ca7ce79a4aed"
authors = ["Christian Merdon <merdon@wias-berlin.de>", "Patrick Jaap <patrick.jaap@wias-berlin.de>"]
version = "1.0.0"
version = "1.0.1"

[deps]
CommonSolve = "38540f10-b2f7-11e9-35d8-d573e4eb0ff2"
Expand Down
2 changes: 1 addition & 1 deletion src/common_operators/bilinear_operator_dg.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1070,7 +1070,7 @@ function assemble!(A::FEMatrix, O::BilinearOperatorDG{Tv, UT}, sol = nothing; as
ind_args = O.u_args
return if length(O.u_args) > 0
build_assembler!(A.entries, O, [A[j, j] for j in ind_test], [A[j, j] for j in ind_ansatz], [sol[j] for j in ind_args]; kwargs...)
O.assembler(A.entries, [sol[j] for j in ind_args])
O.assembler(A.entries, nothing, [sol[j] for j in ind_args])
else
build_assembler!(A.entries, O, [A[j, j] for j in ind_test], [A[j, j] for j in ind_ansatz]; kwargs...)
O.assembler(A.entries, nothing)
Expand Down
Loading