Skip to content

Conversation

pjaap
Copy link
Member

@pjaap pjaap commented Jun 13, 2025

This implements broken plots for broken scalar FE types.

Demo with dof-number as value for easy checking:

    xgrid = grid_unitsquare(Triangle2D)

    # broken FE space
    FES = FESpace{L2P0{1}}(xgrid)
    feVector = FEVector(FES)

    # value = dof for testing
    feVector.entries .= 1:(length(feVector.entries))

    ExtendableFEM.plot([grid(1),id(1)],feVector, Plotter = GLMakie)

image

and for L2P1:
image

with average_broken_plots = true we get the old behavior:
image

@pjaap pjaap requested a review from chmerdon June 13, 2025 13:08
@pjaap
Copy link
Member Author

pjaap commented Jun 13, 2025

If also works OOTB with slice plots (3D unitcube slices at x = 0.5):
image

@pjaap pjaap force-pushed the feature/broken-plots branch from 2eb2a17 to 33b19e1 Compare June 13, 2025 13:27
@pjaap
Copy link
Member Author

pjaap commented Jun 13, 2025

Removed the norm from the title in the plots. This was a C&P error.

@pjaap pjaap force-pushed the feature/broken-plots branch from 33b19e1 to e955b86 Compare June 16, 2025 09:59
@pjaap pjaap force-pushed the feature/broken-plots branch from e955b86 to f84ec68 Compare June 16, 2025 10:04
@pjaap pjaap force-pushed the feature/broken-plots branch from 6c1c442 to 4706017 Compare June 16, 2025 14:03
Copy link
Member

@chmerdon chmerdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pjaap pjaap merged commit 9d96bd2 into master Jun 17, 2025
8 checks passed
@pjaap pjaap deleted the feature/broken-plots branch June 17, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants