Skip to content

Conversation

pjaap
Copy link
Member

@pjaap pjaap commented Jun 17, 2025

No description provided.

pjaap added 2 commits June 17, 2025 09:41
Now the user can manually plot broken functions into a GridVisualizer

Two identical methods were combined with a Union type
@pjaap
Copy link
Member Author

pjaap commented Jun 17, 2025

The plotting logic is a bit messy. This adds another if/else in the code. We should clean this up "in the future" :)

@chmerdon
Copy link
Member

I just had a look at the documentation and expected lots of discontinuous plots, but I only found few. For example in https://wias-pdelib.github.io/ExtendableFEM.jl/dev/module_examples/Example201_PoissonProblem/ the gradient is plotted still as a continuous function, since taking the Gradient from a continuous H1P1 element does not trigger the piecewise plotting. Is that fine or do we want to change that?

@chmerdon
Copy link
Member

and I like the id(u,c) operator

@pjaap
Copy link
Member Author

pjaap commented Jun 17, 2025

I just had a look at the documentation and expected lots of discontinuous plots, but I only found few. For example in https://wias-pdelib.github.io/ExtendableFEM.jl/dev/module_examples/Example201_PoissonProblem/ the gradient is plotted still as a continuous function, since taking the Gradient from a continuous H1P1 element does not trigger the piecewise plotting. Is that fine or do we want to change that?

The gradient is a vectorplot and this is currently not implemented. Only scalarplot for broken FE.

@chmerdon
Copy link
Member

Yes, but I mean the abs-plot of the vector.

@pjaap
Copy link
Member Author

pjaap commented Jun 17, 2025

I just talked to @Liameloy if he wants to refactor the whole plotting logic into vector/scalar/grid with and without abs and broken or not. He will have a look after next Berufsschule week.

@pjaap
Copy link
Member Author

pjaap commented Jun 17, 2025

It is also hard to detect which operators produce broken functions. grad of H1P1 does, but grad of H1P2 not. Or we plot first order opearators grad, div, ... always broken? We should discuss a concept, I guess

@chmerdon
Copy link
Member

chmerdon commented Jun 17, 2025

grad of H1P2 also produces (L2P1) broken functions, we (unfortunately) don't have H2 elements yet :). I think we can base this on NeededDerivative4Operator(operator) > 0.

@pjaap
Copy link
Member Author

pjaap commented Jun 17, 2025

Pls merge if it is fine. I want to release the new version for the pre-strain plots 😄

Copy link
Member

@chmerdon chmerdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@chmerdon chmerdon merged commit 2483995 into master Jun 17, 2025
8 checks passed
@pjaap
Copy link
Member Author

pjaap commented Jun 17, 2025

grad of H1P2 also produces (L2P1) broken functions, we (unfortunately) don't have H2 elements yet :). I think we can base this on NeededDerivative4Operator(operator) > 0.

That's true. I had a mix-up. NeededDerivative4Operator(operator) > 0 is indeed the key. Let's come back to this thread in two weeks.

@pjaap pjaap deleted the feature/broken-plots branch June 17, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants