Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim down to a minimal core #176

Merged
merged 5 commits into from
Sep 23, 2019
Merged

Slim down to a minimal core #176

merged 5 commits into from
Sep 23, 2019

Conversation

domenic
Copy link
Collaborator

@domenic domenic commented Sep 9, 2019

This re-focuses the import maps explainer and specification on a minimal core which is more likely to be implementable and agreeable in the near future. It removes multiple import map support, fallback support, and built-in module support for now. The explainer contains a "Further work" section which details these and other potential future work.

In terms of normative changes:

  • The parser now rejects non-string addresses, so arrays and null are no longer valid
  • The resolver becomes much simpler due to this change, as well as the removal of built-in module support
  • There is no more procedure for merging import maps
  • Script fetches only wait on a single "pending import map script" instead of a "list of pending import map scripts"
  • Any further import maps are not parsed, and generate "error" events on their <script> elements

This is not ready to merge yet as I've only updated the reference implementation (not spec) for parsing and resolving. All the content is there though, so this could be reviewed as-is.


Preview | Diff

This re-focuses the import maps explainer and specification on a minimal core which is more likely to be implementable and agreeable in the near future. It removes multiple import map support, fallback support, and built-in module support for now. The explainer contains a "Further work" section which details these and other potential future work.

In terms of normative changes:

* The parser now rejects non-string addresses, so arrays and null are no longer valid
* The resolver becomes much simpler due to this change, as well as the removal of built-in module support
* There is no more procedure for merging import maps
* Script fetches only wait on a single "pending import map script" instead of a "list of pending import map scripts"
@jkrems
Copy link
Contributor

jkrems commented Sep 9, 2019

Does removal of array support complicate its future addition? It would require user-agent sniffing (or waiting a long time) to use array syntax if past versions wouldn't be able to accept them.

For node we currently plan to support synchronous arrays only, e.g. we'll never try to fetch more than one of the resolutions. That way a "protocol whitelist" is enough to make the decision while still allowing for future std: modules or more complex guards.

These were probably preexisting
@domenic
Copy link
Collaborator Author

domenic commented Sep 18, 2019

Does removal of array support complicate its future addition? It would require user-agent sniffing (or waiting a long time) to use array syntax if past versions wouldn't be able to accept them.

Or feature detection, using the error event to detect parse errors.

However, I find it unlikely that we'll add the array syntax back at any point, given the implementation complexities that come with it, and the standards quagmire around built-in modules. I currently have no plans to do so.

For node we currently plan to support synchronous arrays only, e.g. we'll never try to fetch more than one of the resolutions. That way a "protocol whitelist" is enough to make the decision while still allowing for future std: modules or more complex guards.

I would suggest following the spec and not supporting arrays at all.

@jkrems
Copy link
Contributor

jkrems commented Sep 18, 2019

I would suggest following the spec and not supporting arrays at all.

To clarify: We're not literally implementing import maps (at least not yet). Unfortunately there are use cases that require declarative switching between implementations so we'll have to implement something in node and likely rather sooner than later or the ecosystem will find a way™.

@domenic domenic marked this pull request as ready for review September 23, 2019 07:58
@domenic
Copy link
Collaborator Author

domenic commented Sep 23, 2019

I finished this off, and will merge it now in the interest of having an up-to-date explainer. Review still appreciated.

@domenic domenic merged commit 6f99d47 into master Sep 23, 2019
@domenic domenic deleted the level1 branch September 23, 2019 07:59
MylesBorins added a commit to tc39/proposal-top-level-await that referenced this pull request Oct 1, 2019
import-maps are no longer aiming to support fallbacks, at leas in the
initial implementation. We should remove the reference in the explainer

Refs: WICG/import-maps#176
littledan pushed a commit to tc39/proposal-top-level-await that referenced this pull request Oct 1, 2019
import-maps are no longer aiming to support fallbacks, at leas in the
initial implementation. We should remove the reference in the explainer

Refs: WICG/import-maps#176
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 4, 2019
This CL splits some WPT tests into
- wpt/import-maps/core/ that tests the core features after
  WICG/import-maps#176, and
- wpt/import-maps/builtin-support/ that requires pre-#176 built-in module
  and fallback support,

in order to test builtin- and non-builtin- versions easier.

Bug: 1010751
Change-Id: I9f4793f64fa0ad267fa1d4e43d5597d94a5cc541
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 15, 2019
This CL splits some WPT tests into
- wpt/import-maps/core/ that tests the core features after
  WICG/import-maps#176, and
- wpt/import-maps/builtin-support/ that requires pre-#176 built-in module
  and fallback support,

in order to test builtin- and non-builtin- versions easier.

Bug: 1010751
Change-Id: I9f4793f64fa0ad267fa1d4e43d5597d94a5cc541
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 15, 2019
This CL imports post-#176 upstream reference implementation's tests
into wpt/import-maps/core-imported/, and
executes them under virtual/import-maps-without-builtin-modules/.

The pre-#176 existing tests are still left under
wpt/import-maps/imported/, which are excluded
by this CL from virtual/import-maps-without-builtin-modules.

To match with the expectation of post-#176 tests,
this CL modifies ImportMap::ToString() to output
strings (not single-element arrays) as right hand side.

WICG/import-maps#176

Bug: 990561, 1010751
Change-Id: I652b35969d48e0147d07aa869ca3a97004f2f7a1
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 15, 2019
This CL imports post-#176 upstream reference implementation's tests
into wpt/import-maps/core-imported/, and
executes them under virtual/import-maps-without-builtin-modules/.

The pre-#176 existing tests are still left under
wpt/import-maps/imported/, which are excluded
by this CL from virtual/import-maps-without-builtin-modules.

To match with the expectation of post-#176 tests,
this CL modifies ImportMap::ToString() to output
strings (not single-element arrays) as right hand side.

WICG/import-maps#176

Bug: 990561, 1010751
Change-Id: I652b35969d48e0147d07aa869ca3a97004f2f7a1
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 15, 2019
This CL splits some WPT tests into
- wpt/import-maps/core/ that tests the core features after
  WICG/import-maps#176, and
- wpt/import-maps/builtin-support/ that requires pre-#176 built-in module
  and fallback support,

in order to test builtin- and non-builtin- versions easier.

Bug: 1010751
Change-Id: I9f4793f64fa0ad267fa1d4e43d5597d94a5cc541
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 15, 2019
This CL splits some WPT tests into
- wpt/import-maps/core/ that tests the core features after
  WICG/import-maps#176, and
- wpt/import-maps/builtin-support/ that requires pre-#176 built-in module
  and fallback support,

in order to test builtin- and non-builtin- versions easier.

Bug: 1010751
Change-Id: I9f4793f64fa0ad267fa1d4e43d5597d94a5cc541
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 15, 2019
This CL imports post-#176 upstream reference implementation's tests
into wpt/import-maps/core-imported/, and
executes them under virtual/import-maps-without-builtin-modules/.

The pre-#176 existing tests are still left under
wpt/import-maps/imported/, which are excluded
by this CL from virtual/import-maps-without-builtin-modules.

To match with the expectation of post-#176 tests,
this CL modifies ImportMap::ToString() to output
strings (not single-element arrays) as right hand side.

WICG/import-maps#176

Bug: 990561, 1010751
Change-Id: I652b35969d48e0147d07aa869ca3a97004f2f7a1
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 15, 2019
This CL imports post-#176 upstream reference implementation's tests
into wpt/import-maps/imported/, and
executes them under virtual/import-maps-without-builtin-modules/.

The pre-#176 existing tests are still left under
wpt/import-maps/builtin-support.tentative/imported/, which are excluded
by this CL from virtual/import-maps-without-builtin-modules.

To match with the expectation of post-#176 tests,
this CL modifies ImportMap::ToString() to output
strings (not single-element arrays) as right hand side.

WICG/import-maps#176

Bug: 990561, 1010751
Change-Id: I652b35969d48e0147d07aa869ca3a97004f2f7a1
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 15, 2019
This CL imports post-#176 upstream reference implementation's tests
into wpt/import-maps/imported/, and
executes them under virtual/import-maps-without-builtin-modules/.

The pre-#176 existing tests are still left under
wpt/import-maps/builtin-support.tentative/imported/, which are excluded
by this CL from virtual/import-maps-without-builtin-modules.

To match with the expectation of post-#176 tests,
this CL modifies ImportMap::ToString() to output
strings (not single-element arrays) as right hand side.

WICG/import-maps#176

Bug: 990561, 1010751
Change-Id: I652b35969d48e0147d07aa869ca3a97004f2f7a1
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 15, 2019
This CL imports post-#176 upstream reference implementation's tests
into wpt/import-maps/imported/, and
executes them under virtual/import-maps-without-builtin-modules/.

The pre-#176 existing tests are still left under
wpt/import-maps/builtin-support.tentative/imported/, which are excluded
by this CL from virtual/import-maps-without-builtin-modules.

To match with the expectation of post-#176 tests,
this CL modifies ImportMap::ToString() to output
strings (not single-element arrays) as right hand side.

WICG/import-maps#176

Bug: 990561, 1010751
Change-Id: I652b35969d48e0147d07aa869ca3a97004f2f7a1
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 15, 2019
This CL imports post-#176 upstream reference implementation's tests
into wpt/import-maps/imported/, and
executes them under virtual/import-maps-without-builtin-modules/.

The pre-#176 existing tests are still left under
wpt/import-maps/builtin-support.tentative/imported/, which are excluded
by this CL from virtual/import-maps-without-builtin-modules.

To match with the expectation of post-#176 tests,
this CL modifies ImportMap::ToString() to output
strings (not single-element arrays) as right hand side.

WICG/import-maps#176

Bug: 990561, 1010751
Change-Id: I652b35969d48e0147d07aa869ca3a97004f2f7a1
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 16, 2019
This CL splits some WPT tests into
- wpt/import-maps/core/ that tests the core features after
  WICG/import-maps#176, and
- wpt/import-maps/builtin-support.tentative/ that
  requires pre-#176 built-in module and fallback support,

in order to test builtin- and non-builtin- versions easier.

Bug: 1010751
Change-Id: I9f4793f64fa0ad267fa1d4e43d5597d94a5cc541
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 16, 2019
This CL splits some WPT tests into
- wpt/import-maps/core/ that tests the core features after
  WICG/import-maps#176, and
- wpt/import-maps/builtin-support.tentative/ that
  requires pre-#176 built-in module and fallback support,

in order to test builtin- and non-builtin- versions easier.

Bug: 1010751
Change-Id: I9f4793f64fa0ad267fa1d4e43d5597d94a5cc541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839428
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706510}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 16, 2019
This CL splits some WPT tests into
- wpt/import-maps/core/ that tests the core features after
  WICG/import-maps#176, and
- wpt/import-maps/builtin-support.tentative/ that
  requires pre-#176 built-in module and fallback support,

in order to test builtin- and non-builtin- versions easier.

Bug: 1010751
Change-Id: I9f4793f64fa0ad267fa1d4e43d5597d94a5cc541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839428
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706510}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 16, 2019
This CL imports post-#176 upstream reference implementation's tests
into wpt/import-maps/imported/, and
executes them under virtual/import-maps-without-builtin-modules/.

The pre-#176 existing tests are still left under
wpt/import-maps/builtin-support.tentative/imported/, which are excluded
by this CL from virtual/import-maps-without-builtin-modules.

To match with the expectation of post-#176 tests,
this CL modifies ImportMap::ToString() to output
strings (not single-element arrays) as right hand side.

WICG/import-maps#176

Bug: 990561, 1010751
Change-Id: I652b35969d48e0147d07aa869ca3a97004f2f7a1
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 16, 2019
This CL imports post-#176 upstream reference implementation's tests
into wpt/import-maps/imported/, and
executes them under virtual/import-maps-without-builtin-modules/.

The pre-#176 existing tests are still left under
wpt/import-maps/builtin-support.tentative/imported/, which are excluded
by this CL from virtual/import-maps-without-builtin-modules.

To match with the expectation of post-#176 tests,
this CL modifies ImportMap::ToString() to output
strings (not single-element arrays) as right hand side.

WICG/import-maps#176

Bug: 990561, 1010751
Change-Id: I652b35969d48e0147d07aa869ca3a97004f2f7a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842928
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706637}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 16, 2019
This CL imports post-#176 upstream reference implementation's tests
into wpt/import-maps/imported/, and
executes them under virtual/import-maps-without-builtin-modules/.

The pre-#176 existing tests are still left under
wpt/import-maps/builtin-support.tentative/imported/, which are excluded
by this CL from virtual/import-maps-without-builtin-modules.

To match with the expectation of post-#176 tests,
this CL modifies ImportMap::ToString() to output
strings (not single-element arrays) as right hand side.

WICG/import-maps#176

Bug: 990561, 1010751
Change-Id: I652b35969d48e0147d07aa869ca3a97004f2f7a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842928
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706637}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Oct 24, 2019
…d to built-in modules, a=testonly

Automatic update from web-platform-tests
[Import Maps] Split out WPT tests related to built-in modules

This CL splits some WPT tests into
- wpt/import-maps/core/ that tests the core features after
  WICG/import-maps#176, and
- wpt/import-maps/builtin-support.tentative/ that
  requires pre-#176 built-in module and fallback support,

in order to test builtin- and non-builtin- versions easier.

Bug: 1010751
Change-Id: I9f4793f64fa0ad267fa1d4e43d5597d94a5cc541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839428
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706510}

--

wpt-commits: bc0ed740d1afbd88607aab23ab23ddc81d685073
wpt-pr: 19517


--HG--
rename : testing/web-platform/tests/import-maps/@std/__dir__.headers => testing/web-platform/tests/import-maps/builtin-support.tentative/@std/__dir__.headers
rename : testing/web-platform/tests/import-maps/@std/blank => testing/web-platform/tests/import-maps/builtin-support.tentative/@std/blank
rename : testing/web-platform/tests/import-maps/@std/none => testing/web-platform/tests/import-maps/builtin-support.tentative/@std/none
rename : testing/web-platform/tests/import-maps/bare/__dir__.headers => testing/web-platform/tests/import-maps/builtin-support.tentative/bare/__dir__.headers
rename : testing/web-platform/tests/import-maps/bare/blank => testing/web-platform/tests/import-maps/builtin-support.tentative/bare/blank
rename : testing/web-platform/tests/import-maps/bare/none => testing/web-platform/tests/import-maps/builtin-support.tentative/bare/none
rename : testing/web-platform/tests/import-maps/bare/std-blank => testing/web-platform/tests/import-maps/builtin-support.tentative/bare/std-blank
rename : testing/web-platform/tests/import-maps/bare/std-none => testing/web-platform/tests/import-maps/builtin-support.tentative/bare/std-none
rename : testing/web-platform/tests/import-maps/static-import.js => testing/web-platform/tests/import-maps/builtin-support.tentative/static-import.js
rename : testing/web-platform/tests/import-maps/@std/__dir__.headers => testing/web-platform/tests/import-maps/core/bare/__dir__.headers
rename : testing/web-platform/tests/import-maps/bare/bare => testing/web-platform/tests/import-maps/core/bare/bare
rename : testing/web-platform/tests/import-maps/bare/cross-origin-bare => testing/web-platform/tests/import-maps/core/bare/cross-origin-bare
rename : testing/web-platform/tests/import-maps/bare/to-bare => testing/web-platform/tests/import-maps/core/bare/to-bare
rename : testing/web-platform/tests/import-maps/bare/to-data => testing/web-platform/tests/import-maps/core/bare/to-data
rename : testing/web-platform/tests/import-maps/static-import.js => testing/web-platform/tests/import-maps/core/static-import.js
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Oct 24, 2019
Automatic update from web-platform-tests
[Import Maps] Import tests

This CL imports post-#176 upstream reference implementation's tests
into wpt/import-maps/imported/, and
executes them under virtual/import-maps-without-builtin-modules/.

The pre-#176 existing tests are still left under
wpt/import-maps/builtin-support.tentative/imported/, which are excluded
by this CL from virtual/import-maps-without-builtin-modules.

To match with the expectation of post-#176 tests,
this CL modifies ImportMap::ToString() to output
strings (not single-element arrays) as right hand side.

WICG/import-maps#176

Bug: 990561, 1010751
Change-Id: I652b35969d48e0147d07aa869ca3a97004f2f7a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842928
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706637}

--

wpt-commits: 2a907985ffc3ea3455fe277c584cadfe70b53623
wpt-pr: 19685


--HG--
rename : testing/web-platform/tests/import-maps/imported/resources/parsing-addresses.js => testing/web-platform/tests/import-maps/builtin-support.tentative/imported/resources/parsing-addresses.js
rename : testing/web-platform/tests/import-maps/imported/resources/parsing-schema.js => testing/web-platform/tests/import-maps/builtin-support.tentative/imported/resources/parsing-schema.js
rename : testing/web-platform/tests/import-maps/imported/resources/parsing-scope-keys.js => testing/web-platform/tests/import-maps/builtin-support.tentative/imported/resources/parsing-scope-keys.js
rename : testing/web-platform/tests/import-maps/imported/resources/parsing-specifier-keys.js => testing/web-platform/tests/import-maps/builtin-support.tentative/imported/resources/parsing-specifier-keys.js
rename : testing/web-platform/tests/import-maps/imported/resources/resolving-builtins.js => testing/web-platform/tests/import-maps/builtin-support.tentative/imported/resources/resolving-builtins.js
rename : testing/web-platform/tests/import-maps/imported/resources/resolving-not-yet-implemented.js => testing/web-platform/tests/import-maps/builtin-support.tentative/imported/resources/resolving-not-yet-implemented.js
rename : testing/web-platform/tests/import-maps/imported/resources/resolving-scopes.js => testing/web-platform/tests/import-maps/builtin-support.tentative/imported/resources/resolving-scopes.js
rename : testing/web-platform/tests/import-maps/imported/resources/resolving.js => testing/web-platform/tests/import-maps/builtin-support.tentative/imported/resources/resolving.js
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Oct 24, 2019
…d to built-in modules, a=testonly

Automatic update from web-platform-tests
[Import Maps] Split out WPT tests related to built-in modules

This CL splits some WPT tests into
- wpt/import-maps/core/ that tests the core features after
  WICG/import-maps#176, and
- wpt/import-maps/builtin-support.tentative/ that
  requires pre-#176 built-in module and fallback support,

in order to test builtin- and non-builtin- versions easier.

Bug: 1010751
Change-Id: I9f4793f64fa0ad267fa1d4e43d5597d94a5cc541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839428
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706510}

--

wpt-commits: bc0ed740d1afbd88607aab23ab23ddc81d685073
wpt-pr: 19517
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Oct 24, 2019
Automatic update from web-platform-tests
[Import Maps] Import tests

This CL imports post-#176 upstream reference implementation's tests
into wpt/import-maps/imported/, and
executes them under virtual/import-maps-without-builtin-modules/.

The pre-#176 existing tests are still left under
wpt/import-maps/builtin-support.tentative/imported/, which are excluded
by this CL from virtual/import-maps-without-builtin-modules.

To match with the expectation of post-#176 tests,
this CL modifies ImportMap::ToString() to output
strings (not single-element arrays) as right hand side.

WICG/import-maps#176

Bug: 990561, 1010751
Change-Id: I652b35969d48e0147d07aa869ca3a97004f2f7a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842928
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706637}

--

wpt-commits: 2a907985ffc3ea3455fe277c584cadfe70b53623
wpt-pr: 19685
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 27, 2019
…d to built-in modules, a=testonly

Automatic update from web-platform-tests
[Import Maps] Split out WPT tests related to built-in modules

This CL splits some WPT tests into
- wpt/import-maps/core/ that tests the core features after
  WICG/import-maps#176, and
- wpt/import-maps/builtin-support.tentative/ that
  requires pre-#176 built-in module and fallback support,

in order to test builtin- and non-builtin- versions easier.

Bug: 1010751
Change-Id: I9f4793f64fa0ad267fa1d4e43d5597d94a5cc541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839428
Commit-Queue: Hiroshige Hayashizaki <hiroshigechromium.org>
Reviewed-by: Domenic Denicola <domenicchromium.org>
Cr-Commit-Position: refs/heads/master{#706510}

--

wpt-commits: bc0ed740d1afbd88607aab23ab23ddc81d685073
wpt-pr: 19517

UltraBlame original commit: 3427c97a50a3fba2fc1411e64180199bef3dcc87
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 27, 2019
Automatic update from web-platform-tests
[Import Maps] Import tests

This CL imports post-#176 upstream reference implementation's tests
into wpt/import-maps/imported/, and
executes them under virtual/import-maps-without-builtin-modules/.

The pre-#176 existing tests are still left under
wpt/import-maps/builtin-support.tentative/imported/, which are excluded
by this CL from virtual/import-maps-without-builtin-modules.

To match with the expectation of post-#176 tests,
this CL modifies ImportMap::ToString() to output
strings (not single-element arrays) as right hand side.

WICG/import-maps#176

Bug: 990561, 1010751
Change-Id: I652b35969d48e0147d07aa869ca3a97004f2f7a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842928
Commit-Queue: Hiroshige Hayashizaki <hiroshigechromium.org>
Reviewed-by: Domenic Denicola <domenicchromium.org>
Cr-Commit-Position: refs/heads/master{#706637}

--

wpt-commits: 2a907985ffc3ea3455fe277c584cadfe70b53623
wpt-pr: 19685

UltraBlame original commit: cfd9e691d824fc831539bf6bd91480a6562cc29c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 27, 2019
…d to built-in modules, a=testonly

Automatic update from web-platform-tests
[Import Maps] Split out WPT tests related to built-in modules

This CL splits some WPT tests into
- wpt/import-maps/core/ that tests the core features after
  WICG/import-maps#176, and
- wpt/import-maps/builtin-support.tentative/ that
  requires pre-#176 built-in module and fallback support,

in order to test builtin- and non-builtin- versions easier.

Bug: 1010751
Change-Id: I9f4793f64fa0ad267fa1d4e43d5597d94a5cc541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839428
Commit-Queue: Hiroshige Hayashizaki <hiroshigechromium.org>
Reviewed-by: Domenic Denicola <domenicchromium.org>
Cr-Commit-Position: refs/heads/master{#706510}

--

wpt-commits: bc0ed740d1afbd88607aab23ab23ddc81d685073
wpt-pr: 19517

UltraBlame original commit: 3427c97a50a3fba2fc1411e64180199bef3dcc87
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 27, 2019
Automatic update from web-platform-tests
[Import Maps] Import tests

This CL imports post-#176 upstream reference implementation's tests
into wpt/import-maps/imported/, and
executes them under virtual/import-maps-without-builtin-modules/.

The pre-#176 existing tests are still left under
wpt/import-maps/builtin-support.tentative/imported/, which are excluded
by this CL from virtual/import-maps-without-builtin-modules.

To match with the expectation of post-#176 tests,
this CL modifies ImportMap::ToString() to output
strings (not single-element arrays) as right hand side.

WICG/import-maps#176

Bug: 990561, 1010751
Change-Id: I652b35969d48e0147d07aa869ca3a97004f2f7a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842928
Commit-Queue: Hiroshige Hayashizaki <hiroshigechromium.org>
Reviewed-by: Domenic Denicola <domenicchromium.org>
Cr-Commit-Position: refs/heads/master{#706637}

--

wpt-commits: 2a907985ffc3ea3455fe277c584cadfe70b53623
wpt-pr: 19685

UltraBlame original commit: cfd9e691d824fc831539bf6bd91480a6562cc29c
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 27, 2019
…d to built-in modules, a=testonly

Automatic update from web-platform-tests
[Import Maps] Split out WPT tests related to built-in modules

This CL splits some WPT tests into
- wpt/import-maps/core/ that tests the core features after
  WICG/import-maps#176, and
- wpt/import-maps/builtin-support.tentative/ that
  requires pre-#176 built-in module and fallback support,

in order to test builtin- and non-builtin- versions easier.

Bug: 1010751
Change-Id: I9f4793f64fa0ad267fa1d4e43d5597d94a5cc541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839428
Commit-Queue: Hiroshige Hayashizaki <hiroshigechromium.org>
Reviewed-by: Domenic Denicola <domenicchromium.org>
Cr-Commit-Position: refs/heads/master{#706510}

--

wpt-commits: bc0ed740d1afbd88607aab23ab23ddc81d685073
wpt-pr: 19517

UltraBlame original commit: 3427c97a50a3fba2fc1411e64180199bef3dcc87
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 27, 2019
Automatic update from web-platform-tests
[Import Maps] Import tests

This CL imports post-#176 upstream reference implementation's tests
into wpt/import-maps/imported/, and
executes them under virtual/import-maps-without-builtin-modules/.

The pre-#176 existing tests are still left under
wpt/import-maps/builtin-support.tentative/imported/, which are excluded
by this CL from virtual/import-maps-without-builtin-modules.

To match with the expectation of post-#176 tests,
this CL modifies ImportMap::ToString() to output
strings (not single-element arrays) as right hand side.

WICG/import-maps#176

Bug: 990561, 1010751
Change-Id: I652b35969d48e0147d07aa869ca3a97004f2f7a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842928
Commit-Queue: Hiroshige Hayashizaki <hiroshigechromium.org>
Reviewed-by: Domenic Denicola <domenicchromium.org>
Cr-Commit-Position: refs/heads/master{#706637}

--

wpt-commits: 2a907985ffc3ea3455fe277c584cadfe70b53623
wpt-pr: 19685

UltraBlame original commit: cfd9e691d824fc831539bf6bd91480a6562cc29c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants