Put a fallback URL at the beginning of signed exchanges #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still needs a definition of request matching in a subsequent PR, and it probably has several mistakes, which I'm hoping my reviewers will catch.
As previously agreed with Chrome's loading team.
This makes it clearer that application/signed-exchange shouldn't parse and reserialize the headers. It suggests that plain responses and Pushed exchanges should serialize and reparse the headers, but they had to do the serialization step anyway, and reparsing ensures that untrusted headers aren't used.
The CBOR structure I was using before was an attempt to be forward-compatible, but now that the context string changes on each draft version, there's no need to include the item names in the message. Fixes WICG#276.
This lets the browser redirect there if it doesn't recognize the version of the signed exchange.
nyaxt
approved these changes
Aug 17, 2018
hajimehoshi
reviewed
Aug 20, 2018
|
|
||
| 1. The map mapping: | ||
| * The byte string ':method' to the byte string containing `exchange`'s | ||
| request's method. | ||
| * The byte string ':url' to the byte string containing `exchange`'s request's |
There was a problem hiding this comment.
I was wondering if we'd need to fix the blow example, that includes ':url' in cbor representation.
There was a problem hiding this comment.
Good catch. I'll file a separate PR for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets the browser redirect there if it doesn't recognize the version of the signed exchange.
This sits on top of #287 and #281, so please only review
99fa76f. It fixes #242.One question here is whether to include the method with the fallback URL. We can't do anything with a non-GET method right now, and after many years of HTTP, the only acceptable methods are GET and HEAD anyway, so I think we should consider dropping the method entirely, although not in this PR.
signed-responses: Preview, Diff
Loading: Preview